make paths positional arguments #29
Conversation
|
|
|
Might need to write more tests to pass the coverage ... :( |
|
Why use click when you can accomplish the same thing with stdlib argparse? |
|
Agreed with @asottile. This feature can be implemented using argparse posargs |
|
I was playing around with Click and thought it might be useful.
|
|
btw, I think we can turn off the annoying coveralls comments unless you guys find them useful. |
|
That still leaves the "check" on pull requests enabled, right? If so, I vote yes. |
|
I vote yes, too. So noisyyyyy. |
|
I've disabled the comments |
| parser.add_argument( | ||
| '--pattern', '-p', metavar='path', action='append', required=True, | ||
| '--pattern', '-p', metavar='PATH', action='append', required=True, | ||
| help='paths to pattern definition files') |
There was a problem hiding this comment.
nit: shouldn't this read "path to pattern definition file" rather than "paths ... to files" ?
There was a problem hiding this comment.
I didn't change it because it can take multiple patterns as far as I know.
|
@asottile @ajm188 @evhub I'll do the following according to the discussion.
|
| @@ -49,21 +49,21 @@ def _read_output_file(): | |||
|
|
|||
|
|
|||
| def test_single_file(): | |||
| args = ["undebt", "-i", method_to_function_input_path, "-p", method_to_function_path, "--verbose"] | |||
| args = ["undebt", "-p", method_to_function_path, "--verbose", method_to_function_input_path] | |||
There was a problem hiding this comment.
Can you change this and the other tests to move the --verbose to the end? I'd like to make sure that if the arguments are of the form undebt -p pattern input that input isn't treated as another pattern, but this test doesn't check that, since the --verbose is in the way.
|
Accepting |
|
@asottile Yes, your solution will work. However, I don't see the point for keeping backward compatibility... If we really care, then I also should not rename --multiprocess to --jobs. |
Click is a Python package for creating beautiful command line interfaces.
This pull request resolves #27.