Skip to content
This repository has been archived by the owner on Apr 22, 2021. It is now read-only.

Refactors _file_processor class to a function #57

Merged
merged 2 commits into from
Sep 13, 2016

Conversation

ajm188
Copy link
Contributor

@ajm188 ajm188 commented Sep 10, 2016

Resolves #53

I also took advantage of the opportunity to clean up some of the pep8 complains in tests/cmd/main_test.py.

Two things:

  1. We now have undebt.cmd.main.process and undebt.cmd.logic.process. We may want to merge these two methods.
  2. I'm not sure how valuable all of these tests in tests/cmd/main_test.py are now, since a few of them were verifying behavior of _file_processor objects.

@paiweilai
Copy link
Contributor

  1. I am fine with the merging.
  2. this is 2? :p

@evhub
Copy link
Contributor

evhub commented Sep 12, 2016

LGTM, although GitHub is indicating there are conflicts, so you should probably rebase first.

@ajm188
Copy link
Contributor Author

ajm188 commented Sep 12, 2016

hehe yeah isn't markdown nifty?

I need to rebase, since I bumped the version in the PR I just merged. I'll let travis run before I merge it.

This is going to be a patch release.

@ajm188
Copy link
Contributor Author

ajm188 commented Sep 13, 2016

Rebase then version bump

@ajm188
Copy link
Contributor Author

ajm188 commented Sep 13, 2016

Bump :)

@paiweilai
Copy link
Contributor

sheep!

@ajm188 ajm188 merged commit 8dd8bf7 into master Sep 13, 2016
@ajm188 ajm188 deleted the file-processor-refactor branch September 13, 2016 21:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants