Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #4 #5

Merged
merged 2 commits into from
Dec 7, 2016
Merged

Fix #4 #5

merged 2 commits into from
Dec 7, 2016

Conversation

Evpok
Copy link

@Evpok Evpok commented Nov 28, 2016

No description provided.

@YoannDupont
Copy link
Owner

Thanks ! Will look into it as soon as possible.

YoannDupont
YoannDupont requested changes Dec 3, 2016
View reviewed changes
Copy link
Owner

@YoannDupont YoannDupont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall behaviour is OK.

However, an exception should be thrown when two modules having the same name are found. Currently, this silently takes the last one found.

@YoannDupont YoannDupont merged commit e2e396a into YoannDupont:master Dec 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YoannDupont YoannDupont YoannDupont approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Evpok @YoannDupont @LoicGrobol