Skip to content
This repository has been archived by the owner on Oct 4, 2022. It is now read-only.

Stories/dt/linkcount #8 #12

Merged
merged 23 commits into from
May 11, 2015
Merged

Stories/dt/linkcount #8 #12

merged 23 commits into from
May 11, 2015

Conversation

terw-dan
Copy link
Member

Added linkcounter, including checks for outbound links and nofollow attribute, based on the input textstring in stead of DOMelements.

Fixes #8

created function for counting links and checking type of links and nofollow.
@@ -0,0 +1,18 @@
{
"boss": true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should use single quote's instead of double ones.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since in JavaScript there is no real difference between singles and doubles I decided to do everything with doubles, so if there is singlequote in a textstring it doesn't have to be escaped.


/**
* rates the keyword density against given number
* @param keywordDensity
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is type type of keywordDensity?

Something like @param integer keywordDensity makes it easier to understand.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added types to the @params

@andizer andizer mentioned this pull request Apr 22, 2015
omarreiss added a commit that referenced this pull request May 11, 2015
@omarreiss omarreiss merged commit 38cedc2 into master May 11, 2015
@omarreiss omarreiss deleted the stories/DT/linkcount-#8 branch May 11, 2015 11:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants