Skip to content
This repository has been archived by the owner on Oct 4, 2022. It is now read-only.

Rename feature-toggle to feature-flag #246

Merged
merged 6 commits into from
Apr 26, 2019
Merged

Rename feature-toggle to feature-flag #246

merged 6 commits into from
Apr 26, 2019

Conversation

maartenleenders
Copy link
Contributor

@maartenleenders maartenleenders commented Apr 24, 2019 •
edited by nataliashitova
Loading

Summary

Relevant technical choices:

  • N/A

Test instructions

This PR can be tested by following these steps:

Impact check

  • This PR affects the following parts of the plugin, which may require extra testing:
    • Feature flags.

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unittests to verify the code works as intended

Fixes #244

@maartenleenders maartenleenders mentioned this pull request Apr 24, 2019
Open
@nataliashitova nataliashitova changed the base branch from develop to feature/internal-linking April 25, 2019 14:19
@nataliashitova nataliashitova changed the base branch from feature/internal-linking to develop April 25, 2019 14:22
@nataliashitova nataliashitova changed the base branch from develop to feature/internal-linking April 25, 2019 14:22
@manuelaugustin manuelaugustin added this to the Internal linking milestone Apr 26, 2019
@manuelaugustin
Copy link
Contributor

CR & acceptance 👍

@manuelaugustin manuelaugustin merged commit 02d77d5 into feature/internal-linking Apr 26, 2019
@manuelaugustin manuelaugustin deleted the 244-rename-feature-toggle-to-feature-flag branch April 26, 2019 09:22
@manuelaugustin manuelaugustin mentioned this pull request Apr 30, 2019
Merged
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Internal linking
Development

Successfully merging this pull request may close these issues.
3 participants
@maartenleenders @manuelaugustin @nataliashitova