-
Notifications
You must be signed in to change notification settings - Fork 54
Add focus style to wizard navigation buttons #8
Conversation
Bump the ECMAScript version to 2017
@afercia When merging What used to be |
Solved merge conflicts. Also, I've improved the focus style trying to better respect the original design. Right now, these "links" (actually they're buttons) have a bottom border to emulate a link style. My previous change removed the bottom border in favor of Now, I'm using a different CSS to make this line more spaced from the text. In the screenshot below: normal and focused: The fourth commit is only for coding standards, you can ignore it and check only the third one. |
CR Done 👍 |
Acceptance 👍 |
Supersedes Yoast/yoast-components#834
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
#5b9dd9
blue color to the palette: this is the color used by WordPress for focusTest instructions
Note:
while working on this I've noticed the state of the CSS could be improved. There are duplications of rules between the plugin and the yoast-components. The preview of the Wizard in the standalone app looks different from the Wizard in the plugin. This doesn't help in testing. Also, there shouldn't be hardcoded colors in the yoast-components (only colors from the palette should be used).
Will create a separate issue.
UI changes
Fixes Yoast/yoast-components#833