This repository has been archived by the owner on Oct 4, 2022. It is now read-only.
Let makeOutboundLink handle rel attribute automatically #9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes Yoast/yoast-components#829
Summary
This PR can be summarized in the following changelog entry:
rel
attribute for links that open in a new browser's tabRelevant technical choices:
rel
attribute automaticallyrel={ null }
as they're no longer necessarymakeOutboundLink
instead of hardcoded links where necessaryAs per Yoast/wordpress-seo#4605 (comment), the desired behavior is:
noopener
for all the non-yoast.com external linksTest instructions
This PR can be tested by following these steps:
makeOutboundLink
e.g.:UI changes
Fixes Yoast/yoast-components#828