Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for passing custom messages #114

Closed
wants to merge 1 commit into from
Closed

Allow for passing custom messages #114

wants to merge 1 commit into from

Conversation

diedexx
Copy link
Member

@diedexx diedexx commented Dec 14, 2021

WIP: Still need to update tests

Context

  • The built-in messaging is very specific for PHP 5.6 which is no longer relevant. Instead of having to release WHIP with a new message for every PHP version, we need to be able to provide a custom message.

Summary

This PR can be summarized in the following changelog entry:

  • Add support for customized messages.

Relevant technical choices:

  • BC break: the WordPress fasade now requires an array per component instead of just a version constraint. This is done to match a version requirement to message.
  • BC break: I've added version and operator to the WHIP_Requirement interface. The code already relied on these functions. and in the context of WHIP every requirement is a version constraint, so I didn't think adding w WHIL_Version_Requirement. was the way to go.

@diedexx diedexx force-pushed the custom-messaging branch 2 times, most recently from c33501c to da0d3c3 Compare December 14, 2021 12:09
@diedexx
Copy link
Member Author

diedexx commented Oct 3, 2023

No longer relevant - closing

@diedexx diedexx closed this Oct 3, 2023
@diedexx diedexx deleted the custom-messaging branch October 3, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant