Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore title separators focus style #12186

Merged
merged 4 commits into from
Mar 6, 2019
Merged

Conversation

afercia
Copy link
Contributor

@afercia afercia commented Feb 6, 2019

Summary

This PR can be summarized in the following changelog entry.

  • Restore focus indication on the title separators user interface

Relevant technical choices:

  • removes the box-shadow, as the current style can be done with border only
  • added bonus: border works also in Windows High Contrast mode
  • on focus, the border style changes to dashed

Screenshot of normal state:

normal state

Screenshot of focus state:

screenshot 2019-02-06 at 17 09 37

Test instructions

  • on trunk:
    • use the keyboard and focus the first separator
    • notice there's no style change
    • use arrow keys to focus the other separators: still no style change
  • on this branch:
    • build the CSS
    • repeat the steps above
    • notice the style change

Update: test also in the Configuration wizard:

  • yarn link the yoast-components branch 12144-title-separator-focus
  • build the assets
  • go in the Configuration wizard > step 9
  • check the title separators look the same as in the Settings page and the focus style works the same

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Fixes #12144

@afercia afercia added the UI change PRs that result in a change in the UI label Feb 6, 2019
@afercia
Copy link
Contributor Author

afercia commented Feb 13, 2019

Forgot to make the same change in the configuration wizard. On it.

@afercia afercia self-assigned this Feb 13, 2019
@afercia afercia removed their assignment Feb 13, 2019
@abotteram
Copy link
Contributor

CR 👍

@hwinne hwinne added this to the 10.1 milestone Mar 6, 2019
@hwinne hwinne merged commit 8dfe239 into trunk Mar 6, 2019
@hwinne hwinne deleted the 12144-title-separator-focus branch March 6, 2019 12:25
@afercia
Copy link
Contributor Author

afercia commented Mar 14, 2019

Forgot to update the PR description with the design feedback from Yoast/yoast-components#826 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI change PRs that result in a change in the UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants