Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ACF4 code #276

Merged
merged 2 commits into from
Sep 16, 2020
Merged

Remove ACF4 code #276

merged 2 commits into from
Sep 16, 2020

Conversation

enricobattocchi
Copy link
Member

Summary

This PR can be summarized in the following changelog entry:

  • Remove all ACF 4-specific code.

Relevant technical choices:

  • the JS test is not actually working. The ACF4 tests have been removed from there anyway.

Test instructions

This PR can be tested by following these steps:

  • Install ACF4, the latest release for the 4.* branch can be downloaded here
  • Install Yoast SEO
  • checkout this branch and activate
  • create a new group of custom fields for posts in ACF, sticking to just the ones that allow you to add texts (they should be Textbox, Textarea, Email, WYSIWYG)
  • edit a post, and see that adding text in those fields doesn't change the number of words counted by the SEO analysis
  • see alsto that everything else is working and there are no fatal errors in the console that break the behaviour of the block editor, or of Yoast SEO.
  • perform the same test with Classic Editor.
  • delete ACF4 and installa ACF5 Free (you can do it from Plugins→Add new, otherwise download from here)
  • create a new group of custom fields for posts in ACF, you can import the ZIP that you can find in this PR, rememeber that Repeater and Flexible types won't be working.
  • test that the analysis is working (follow the suggestions to test P3-147 Fix refresh analysis #275) and there are no console errors.
  • perform the same test with Classic Editor.
  • Remove ACF5 and install ACF 5 Pro, this would enable Repeater and Flexible fields if you are using the zip from above
  • test that the analysis is working (follow the suggestions to test P3-147 Fix refresh analysis #275) and there are no console errors.
  • perform the same test with Classic Editor.

Fixes [P3-167]

@enricobattocchi enricobattocchi added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Sep 15, 2020
Copy link
Contributor

@jcomack jcomack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR done 👍

@JesserH
Copy link
Contributor

JesserH commented Sep 16, 2020

Acceptance ✅

@JesserH JesserH merged commit d4746a7 into release/3.0 Sep 16, 2020
@JesserH JesserH deleted the P3-167-remove-acf4-code branch September 16, 2020 13:53
@IreneStr IreneStr added this to the 3.0 milestone Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants