Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localize the onboarding wizard #64

Merged
merged 6 commits into from
Sep 15, 2016
Merged

Conversation

atimmer
Copy link
Contributor

@atimmer atimmer commented Sep 13, 2016

This makes it possible to translate the next and previous buttons

Inspired by i18n-calypso, but Automattic/i18n-calypso#19 blocks us from using it.

Required for Yoast/wordpress-seo#5582

@yoastbot
Copy link
Collaborator

Thanks for your contribution! For your convenience and to give some guidelines to the one who is going to review your pull request, here's a checklist:

  • The pull request has a clear description which summarizes the purpose and the technical changes made.
  • Unit tests exist which cover the modified or added code.
  • The tests pass.
  • The pull request doesn't add duplicate code.
  • The pull request follows single responsibility principle for all functions, methods and objects.
  • Functions, methods, objects and variables added by this pull request have descriptive names that make it easy and intuitive to understand what they are about.
  • Documentation is descriptive.
  • The code in this pull request doesn't introduce any security issues. For reference: OWASP top ten vulnerabilities.

* @param {Object} ComposedComponent The original React component.
*/
export function localize( ComposedComponent ) {
let componentName = ComposedComponent.displayName || ComposedComponent.name || '';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use double quotes.

@jcomack
Copy link
Contributor

jcomack commented Sep 14, 2016

CR done. 👷

Acceptance done as well. Translations work, however I do get the following error.

yoast_seo_ _setup_wizard

I cannot get rid of this issue despite clearing out my node_modules and reinstalling. Also, for some reason, I cannot see why the Travis builds keep failing, as Travis says the repository doesn't exist.

@atimmer atimmer added this to the 1.0 milestone Sep 15, 2016
@atimmer
Copy link
Contributor Author

atimmer commented Sep 15, 2016

The error has nothing to do with this PR. I have fixed it on develop when not using npm link.

@atimmer atimmer merged commit a02ec5b into develop Sep 15, 2016
@atimmer atimmer deleted the stories/at/translate-next-previous branch September 15, 2016 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants