implement session.all() #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wtflink
force-pushed
the
implement-session.all()
branch
from
6f0178e
to
49adffc
Compare
wtflink
force-pushed
the
implement-session.all()
branch
from
49adffc
to
e559ffd
Compare
Codecov Report
@@ Coverage Diff @@
## master #343 +/- ##
==========================================
+ Coverage 90.34% 90.37% +0.02%
==========================================
Files 112 112
Lines 3324 3334 +10
Branches 791 791
==========================================
+ Hits 3003 3013 +10
Misses 281 281
Partials 40 40
Continue to review full report at Codecov.
|
wtflink
force-pushed
the
implement-session.all()
branch
from
e559ffd
to
644ab17
Compare
chentsulin
requested changes
Oct 9, 2018
src/session/SessionStore.js
Outdated
| @@ -5,6 +5,7 @@ import { type Session } from './Session'; | |||
| export interface SessionStore { | |||
| init(): Promise<SessionStore>; | |||
| read(key: string): Promise<Session | null>; | |||
| all(): Promise<Array<?Session>>; | |||
There was a problem hiding this comment.
Promise<Array<Session>>
chentsulin
requested changes
Oct 9, 2018
| @@ -27,6 +27,10 @@ export default class CacheBasedSessionStore implements SessionStore { | |||
| return (this._cache.get(key): any); | |||
| } | |||
|
|
|||
| async all(): Promise<Array<?Session>> { | |||
There was a problem hiding this comment.
Promise<Array<Session>>
chentsulin
reviewed
Oct 9, 2018
src/session/MongoSessionStore.js
Outdated
| @@ -8,6 +7,7 @@ import { type Session } from './Session'; | |||
| import { type SessionStore } from './SessionStore'; | |||
|
|
|||
| type MongoCollection = { | |||
| find: () => { toArray: () => Promise<Array<any>> }, | |||
There was a problem hiding this comment.
find returns a Cursor: http://mongodb.github.io/node-mongodb-native/2.2/api/Cursor.html
type Cursor = {
toArray: () => Promise<Array<any>>
};
type MongoCollection = {
find: () => Cursor
//
};
chentsulin
reviewed
Oct 9, 2018
src/session/MongoSessionStore.js
Outdated
| @@ -61,6 +61,17 @@ export default class MongoSessionStore implements SessionStore { | |||
| } | |||
| } | |||
|
|
|||
| async all(): Promise<Array<?Session>> { | |||
| try { | |||
There was a problem hiding this comment.
We should not try catch here for the user, just return it:
return this._sessions.find().toArray();
wtflink
force-pushed
the
implement-session.all()
branch
2 times, most recently
from
f909a50
to
6c2d9e8
Compare
chentsulin
reviewed
Oct 11, 2018
| await store.put('x', { a: 1 }, 5); | ||
| await store.put('y', { a: 2 }, 5); | ||
|
|
||
| const result1 = await store.all(); |
There was a problem hiding this comment.
why using result1 instead of result?
chentsulin
reviewed
Oct 11, 2018
|
|
||
| const result1 = await store.all(); | ||
|
|
||
| expect(result1).toEqual(expect.arrayContaining([{ a: 1 }, { a: 2 }])); |
There was a problem hiding this comment.
This should work without arrayContaining
chentsulin
reviewed
Oct 11, 2018
src/session/FileSessionStore.js
Outdated
| @@ -39,6 +39,11 @@ export default class FileSessionStore implements SessionStore { | |||
| return session; | |||
| } | |||
|
|
|||
| async all(): Promise<Array<Session>> { | |||
| const sessions = await this._jfs.all(); | |||
| return sessions; | |||
There was a problem hiding this comment.
return this._jfs.all()
wtflink
force-pushed
the
implement-session.all()
branch
2 times, most recently
from
cd14741
to
fc50702
Compare
chentsulin
reviewed
Oct 17, 2018
src/cache/RedisCacheStore.js
Outdated
|
|
||
| while (cursor !== '0') { | ||
| /* eslint-disable no-await-in-loop */ | ||
| const result = await this._redis.scan(cursor); |
There was a problem hiding this comment.
const [nextCursor, newkeys] = await this._redis.scan(cursor);
cursor = nextCursor;
keys = keys.concat(newkeys);
wtflink
force-pushed
the
implement-session.all()
branch
from
fc50702
to
4fc6fa2
Compare
wtflink
force-pushed
the
implement-session.all()
branch
from
4fc6fa2
to
6053ec3
Compare
chentsulin
approved these changes
Oct 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #316