-
Notifications
You must be signed in to change notification settings - Fork 734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exemplify production image build #155
base: master
Are you sure you want to change the base?
Conversation
We should also recommend |
Maybe we'll have to maintain an example production manifest. My hopes on a simple patch command were a bit optimistic, as the init container and the volume mount needs to be removed. That'll make patch dangerous for forks that have modified those lists in the original manifest. For now I've:
... in a testing environment of course :) |
An alternative would be to instead build a dedicated init container image. Now we have to make sure the environment matches from init, where we tweaked the script, to the broker pod.
I'm abandoning this initiative in favor of #167. |
Actually it's still quite interesting for Zookeeper. We could probably move anything that varies (the statefulset scale) to labels/annotations, so that most people will never need to edit the init script. |
Triggered by #154 I realized that for those, like us, who have come to depend on this setup in production it's only implied that you build your own image. There's no example. Upgrades is something you bother doing in production, and there you really want the functionality in
kubectl set image --record=true
andkubectl rollout undo
. With a separate ConfigMap you get the chance to easily tweak the init script and properties to your needs, for example host name resolution for #78, but you don't get a rollback feature.Switching to a production image should be a matter of, whenever you're done tweaking:
This means you can still set up a production cluster using the flexible approach. You can also reverse the above to switch back to experimentation.