Add oscillator to chipdb #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepijndevos
reviewed
Mar 27, 2022
| elif device == 'GW1NS-4': | ||
| bel.portmap['OSCEN'] = "D6" | ||
| elif device == 'GW1NZ-1': | ||
| bel.portmap['OSCEN'] = "A6" |
There was a problem hiding this comment.
maybe have a look if these portmaps are in the dat file. Would make it a lot more clean and portable.
There was a problem hiding this comment.
I searched for 44 and 51 at same offset in NSR-4C and NZ-1 dat files and didn't found them. So it seems it is not in dat file.
| elif device == 'GW1N-1': | ||
| bel = osc.setdefault(f"OSCH", Bel()) | ||
| else: | ||
| raise Exception(f"Oscillator not yet supported on {device}") |
There was a problem hiding this comment.
I wonder if we could tell from the fse tables which type of oscillator the device has?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.