Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile improvements #163

Merged
merged 7 commits into from
Jun 7, 2022
Merged

Makefile improvements #163

merged 7 commits into from
Jun 7, 2022

Conversation

jix
Copy link
Member

@jix jix commented May 30, 2022

Several makefile improvements

  • Updates make help text which was outdated
  • Renames the test target to make test
  • Make make ci error without either cad suite installed (points to make test and allows overriding with make run_ci)
  • Also check for auxiliary tools (btorsim for btor and yices for abc/aiger) when determining which tests can be run with the available tools
  • Automatically rerun test_rules.py when running make test after the set of available tools changed

This should fix everything related to the tests / makefile mentioned in #160

jix added 3 commits May 30, 2022 15:02
@nakengelhardt
Copy link
Member

Sweet! Could you also make the check for btorsim check that it's a version that supports the --vcd argument?

@jix
Copy link
Member Author

jix commented Jun 2, 2022

Now it also checks that btorsim supports the --vcd option. With more complex checks for the available tools now, I also added an option to fail on any skipped tests and enabled that for CI, so we don't accidentally stop running any tests because the detection broke.

This avoids regenerating the test makefile rules when the set of
installed tools changes and is a bit simpler overall.
@jix jix merged commit 2b1a588 into YosysHQ:master Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants