MAX10 updates #4262
Open
MAX10 updates #4262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
povik
reviewed
Mar 6, 2024
techlibs/intel/synth_intel.cc
Outdated
|
|
||
| if (check_label("coarse")) { | ||
| run("synth -run coarse"); | ||
| // run("synth -run coarse"); |
There was a problem hiding this comment.
It's a nit, but please don't leave commented-out pieces of code in.
|
Do you want me to create a new pull request?
Richard
From: Martin Povišer ***@***.***>
Date: Wednesday, 6 March 2024 at 01:54
To: YosysHQ/yosys ***@***.***>
Cc: Richard Herveille ***@***.***>, Author ***@***.***>
Subject: Re: [YosysHQ/yosys] MAX10 updates (PR #4262)
@povik commented on this pull request.
________________________________
In techlibs/intel/synth_intel.cc<#4262 (comment)>:
if (check_label("coarse")) {
- run("synth -run coarse");
+// run("synth -run coarse");
It's a nit, but please don't leave commented-out pieces of code in.
—
Reply to this email directly, view it on GitHub<#4262 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADYKSCOUYZK2Q42G7V7MCRLYW3RVBAVCNFSM6AAAAABEIF2YSCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSMJZGI3TGNBWGY>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
You don't need to, you can change the existing one if you push more commits to the branch from which you have the pull request open (in your case this one). |
|
Done
Richard
From: Martin Povišer ***@***.***>
Date: Thursday, 7 March 2024 at 23:14
To: YosysHQ/yosys ***@***.***>
Cc: Richard Herveille ***@***.***>, Author ***@***.***>
Subject: Re: [YosysHQ/yosys] MAX10 updates (PR #4262)
Do you want me to create a new pull request?
You don't need to, you can change the existing one if you push more commits to the branch from which you have the pull request open (in your case this one<https://github.com/RoaLogic/yosys/tree/master>).
—
Reply to this email directly, view it on GitHub<#4262 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADYKSCL2JQKLAB2TTUL5UQDYXFQNBAVCNFSM6AAAAABEIF2YSCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBVGE3DCNBTHA>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed altsyncram data/address width parameters
Added DSP (mult) support
Updated synth_intel script (~20% higher performance)