Added cast to type support #4284
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I do have a few tests.
How do you want me to include them in the pull request?
Richard
From: Catherine ***@***.***>
Date: Friday, 15 March 2024 at 11:59
To: YosysHQ/yosys ***@***.***>
Cc: Richard Herveille ***@***.***>, Author ***@***.***>
Subject: Re: [YosysHQ/yosys] Added cast to type support (PR #4284)
@whitequark commented on this pull request.
No tests?
—
Reply to this email directly, view it on GitHub<#4284 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADYKSCILLFQNPE7SK2HI4WLYYNAIRAVCNFSM6AAAAABEYQAKHGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSNBQGEYTONJSGI>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
Tests added to the tests/verilog directory
Richard
From: Richard Herveille ***@***.***>
Date: Friday, 15 March 2024 at 14:13
To: YosysHQ/yosys ***@***.***>
Cc: Richard Herveille ***@***.***>
Subject: Re: [YosysHQ/yosys] Added cast to type support (PR #4284)
I do have a few tests.
How do you want me to include them in the pull request?
Richard
From: Catherine ***@***.***>
Date: Friday, 15 March 2024 at 11:59
To: YosysHQ/yosys ***@***.***>
Cc: Richard Herveille ***@***.***>, Author ***@***.***>
Subject: Re: [YosysHQ/yosys] Added cast to type support (PR #4284)
@whitequark commented on this pull request.
No tests?
—
Reply to this email directly, view it on GitHub<#4284 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADYKSCILLFQNPE7SK2HI4WLYYNAIRAVCNFSM6AAAAABEYQAKHGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSNBQGEYTONJSGI>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
whitequark
reviewed
Mar 17, 2024
|
Done
On Mar 17, 2024, at 09:49, Catherine ***@***.***> wrote:
@whitequark commented on this pull request.
Could you also add a test for a cast to a user defined struct please?
—
Reply to this email directly, view it on GitHub<#4284 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADYKSCLIJIL4A42HIUA4FQTYYXCSBAVCNFSM6AAAAABEYQAKHGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSNBRGUZTANRVGM>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for casting to type; e.g.
assign a = int'(some_var);
assign b = my_type_def'(some_var);