read_ilang: allow slicing all sigspecs, not just wires #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whitequark
added a commit
to m-labs/nmigen
that referenced
this pull request
Dec 16, 2018
whitequark
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accepting
sigspec [n:m]is (a) a natural counterpart to accepting{ sigspec1 sigspec2 }, (b) easily expressible via operations onRTLIL::SigSpec, and (c) not easily expressible outside of Yosys.I am hitting the need for this while generating RTLIL in nMigen. I could probably work around it without the Yosys patch but it would be very ugly. Also, the new code is actually simpler!