Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UX issue: notify user of touch needed #319

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

UX issue: notify user of touch needed #319

wants to merge 2 commits into from

Conversation

TomMD
Copy link

@TomMD TomMD commented Jun 26, 2024

Just tell the user a device touch is likely necessary.

@LDVG
Copy link
Contributor

LDVG commented Jun 27, 2024

Thanks for your PR. A couple of quick thoughts:

  • If we are getting rid of the path portion of the prompt, we no longer need the prompt buffer or calls to snprintf.
  • This only prompts you to touch your device if you have to enter a PIN. What about when built-in UV or no UV whatsoever is used? Is there less UX confusion in that case?
  • Should we always prompt for user presence? Should we only prompt during the --verbose mode? Should we introduce a new --quiet flag to completely silence these kinds of prompts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TomMD @LDVG