Improve ldap support #172
Merged
Improve ldap support #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows using the authenticating user's username and password to bind to the LDAP server. This is desirable because it allows for looking up the yubikey attributes without needing to create a service account.
This allows connecting to LDAP servers that only listen on port 389 but use STARTTLS to get a TLS connection
This adds support for using a client cert/key to authenticate to an LDAP server. It is separate from binding with a username and password and can either be used alongside it or with an anonymous bind to the server.
|
Thanks, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds three features to the LDAP support that we needed:
Add the ability to bind as the user logging in
This allows using the authenticating user's username and password to bind to the LDAP server. This is desirable because it allows for looking up the yubikey attributes without needing to create a service account.
Add STARTTLS support
This allows connecting to LDAP servers that only listen on port 389 but use STARTTLS to get a TLS connection
Add support for LDAP client certificate authentication
This adds support for using a client cert/key to authenticate to an LDAP server. It is separate from binding with a username and password and can either be used alongside it or with an anonymous bind to the server. (This one actually closes LDAP Client TLS Certificate #68)