Fix winusb issues under esxi #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and they have issues on ESXi
qpernil
force-pushed
the
fix-winusb-esxi
branch
from
6469bd9
to
cf49623
Compare
qpernil
force-pushed
the
fix-winusb-esxi
branch
from
d8fa991
to
0048bc2
Compare
qpernil
force-pushed
the
fix-winusb-esxi
branch
3 times, most recently
from
2a10735
to
9bac63f
Compare
qpernil
force-pushed
the
fix-winusb-esxi
branch
from
9bac63f
to
cf89441
Compare
GregDomzalski
approved these changes
Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adresses a 2s delay in the status endpoint when run on Windows under ESXi. It essentially does what PR#19 did for libusb but for WinUsb. It now also has a couple of bug fixes that were discovered while implementing & testing.
The delay happens in the 'drain pipe' WinUsb_ReadPipe call, which takes 2s to execute when running under ESXi, despite having set the timeout pipe policy to 10 ms. It Doesn't do that on a physical Windows machine. This is not a big deal now since we only reopen the device on errors.