Add keyboard layout option to OtpStaticPasswordView.qml
#348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
layout.mp4
Currently this program only allows the user to set the OTP static password using the "MODHEX" or "US" scancodes, however many people[1][2][3] including me would like to use other keyboard layouts for this.
The regular expressions used for validation were generated using the scancodes from
yubikey-manager, I made a short Python script for this: https://github.com/piotrpdev/yubikey-scancode-regexp-gen. This way it should be easy to update the regular expressions in the future (I also released the code under The Unlicense).