Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin conftest to v0.20.0 #2

Merged
merged 1 commit into from
Sep 16, 2020
Merged

Pin conftest to v0.20.0 #2

merged 1 commit into from
Sep 16, 2020

Conversation

jalseth
Copy link
Contributor

@jalseth jalseth commented Sep 16, 2020

Pulling from GCS buckets is broken in v0.21.0 (currently latest) so this pins conftest to the latest working version until it is fixed upstream.

Edit -- examples:

$ docker run --rm -it -v $PWD:/data -e GOOGLE_APPLICATION_CREDENTIALS="/data/gcs.json" instrumenta/conftest:v0.21.0 pull gcs::https://www.googleapis.com/storage/v1/redacted-bucket/policy
Error: download policies: client get: error downloading 'https://www.googleapis.com/storage/v1/yes-k8s-policy/policy': RemoveAll .: invalid argument

$ echo $?
1

$ docker run --rm -it -v $PWD:/data -e GOOGLE_APPLICATION_CREDENTIALS="/data/gcs.json" instrumenta/conftest:v0.20.0 pull gcs::https://www.googleapis.com/storage/v1/redacted-bucket/policy

$ echo $?
0

Pulling from GCS buckets is broken in v0.21.0 (currently latest)
so this pins conftest to the latest working version until it is
fixed upstream.
@github-actions
Copy link

Conftest has identified issues with your resources

The following warnings were identified. These are issues that indicate the resources are not following best practices.

  • WARN - .github/test/resources/test.yaml - a warning! you should probably fix this

Copy link

@ducksauz ducksauz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧷

@jalseth jalseth merged commit 734668c into master Sep 16, 2020
@jalseth jalseth deleted the pin-conftest-version branch September 16, 2020 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants