Skip to content
This repository has been archived by the owner on Oct 15, 2023. It is now read-only.

Session 10: Widget Test #40

Merged
merged 12 commits into from
May 23, 2023
Merged

Session 10: Widget Test #40

merged 12 commits into from
May 23, 2023

Conversation

YumNumm
Copy link
Owner

@YumNumm YumNumm commented May 19, 2023 •
edited
Loading

課題

close #23

対応箇所

  • 次の Widget tests を書く
    • WeatherScreen
    • [MUST] 特定の条件で、天気予報画面に晴れの画像が表示されること
    • [MUST] 特定の条件で、天気予報画面に曇りの画像が表示されること
    • [MUST] 特定の条件で、天気予報画面に雨の画像が表示されること
    • [MUST] 特定の条件で、天気予報画面に最高気温が表示されること
    • [MUST] 特定の条件で、天気予報画面に最低気温が表示されること
    • [MUST] 特定の条件で、天気予報画面にダイアログが表示され、特定のメッセージが表示されること
  • 余裕があれば、他の Widget tests も書く
    • App
    • WeatherIconWidget
    • WeatherTemperature

動作

変更はありません。

@github-actions github-actions bot requested a review from blendthink May 19, 2023 09:23
@github-actions
Copy link

Ready for review 🚀

@YumNumm
Copy link
Owner Author

YumNumm commented May 22, 2023

@blendthink おてすきの際にレビューよろしくお願いいたします。

blendthink
blendthink reviewed May 22, 2023
View reviewed changes
Copy link
Collaborator

@blendthink blendthink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YumNumm
いくつかコメントしましたのでご確認お願いします！

lib/features/weather/viewmodel/weather_viewmodel.g.dart Outdated Show resolved Hide resolved
test/utils/display_size.dart Outdated Show resolved Hide resolved
test/app_test.dart Outdated Show resolved Hide resolved
test/features/weather/components/weather_icon_widget_test.dart Outdated Show resolved Hide resolved
test/features/weather/components/weather_icon_widget_test.dart Outdated Show resolved Hide resolved
test/features/weather/components/weather_temperature_widget_test.dart Show resolved Hide resolved
test/features/weather/components/weather_temperature_widget_test.dart Show resolved Hide resolved
test/features/weather/screen/weather_screen_test.dart Outdated Show resolved Hide resolved
@YumNumm
Copy link
Owner Author

YumNumm commented May 23, 2023

@blendthink
お忙しい中、丁寧なレビューありがとうございました。
ご指摘頂いた点を修正しましたので、お手すきの際にご確認いただければと思います。

blendthink
blendthink approved these changes May 23, 2023
View reviewed changes
Copy link
Collaborator

@blendthink blendthink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YumNumm YumNumm merged commit 6466e4c into main May 23, 2023
@YumNumm YumNumm deleted the session/10 branch May 23, 2023 07:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blendthink blendthink blendthink approved these changes

Assignees

@YumNumm YumNumm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Session10
2 participants
@YumNumm @blendthink