Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature : add customer licence option #82

Open
Thatoo opened this issue Dec 13, 2023 · 0 comments
Open

Feature : add customer licence option #82

Thatoo opened this issue Dec 13, 2023 · 0 comments

Comments

@Thatoo
Copy link

Thatoo commented Dec 13, 2023

It could be nice to be able to use customer licence.
Ask for it at install and also be able to add (and change if needed) in config panel app

Instead of
ynh_install_extra_app_dependencies --repo="deb https://collaboraoffice.com/repos/CollaboraOnline/CODE-debian${DEBIAN_VERSION_NUMBER} ./ " --package="$pkg_dependencies" --key="https://keyserver.ubuntu.com/pks/lookup?op=get&search=0x0C54D189F4BA284D" 2>/dev/null

it would be

ynh_install_extra_app_dependencies --repo="deb https://collaboraoffice.com/repos/CollaboraOnline/${DEBIAN_VERSION_NUMBER}/customer-deb-${CUSTOMER_LICENCE} ./ " --package="$pkg_dependencies" --key="https://keyserver.ubuntu.com/pks/lookup?op=get&search=0x0C54D189F4BA284D" 2>/dev/null

Well, it would also require to change in _common.sh script

pkg_dependencies="coolwsd code-brand hunspell-de-de hunspell-en-gb hunspell-fr hunspell"

to

pkg_dependencies="coolwsd collabora-online-brand hunspell-de-de hunspell-en-gb hunspell-fr hunspell"

I don't know if it is a good idea finally. I drop the idea here anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant