Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing #95

Merged
merged 7 commits into from
Jul 26, 2023
Merged

Testing #95

merged 7 commits into from
Jul 26, 2023

Conversation

alexAubin
Copy link
Member

No description provided.

@Thatoo
Copy link
Contributor

Thatoo commented Jan 16, 2022

Could it be merged?
Since update to v2.0, only the internal wifi of the raspberry pi is working as hotspot. The panda usb wireless dongle is unfortunately useless...

@alexAubin
Copy link
Member Author

We should be careful about other places where iw_devices is invoked to be consistent:

 $ grep -nr iw_devices ./
./scripts/_common.sh:15:function iw_devices()
./scripts/config:30:    if [[ $(iw_devices) == "" ]]
./scripts/config:79:    if [[ $(iw_devices) == "" ]]
./scripts/config:86:        for device in $(iw_devices | sed "s/,/ /g")
./scripts/install:133:wifi_device=$(iw_devices | awk -F\| '{ print $1 }')
./scripts/restore:106:wifi_device=$(iw_devices | awk -F\| '{ print $1 }')
./scripts/upgrade:167:wifi_device=$(iw_devices | awk -F\| '{ print $1 }')

@zamentur : do you know why in install/restore/upgrade we seem to be using | as a separator (which indeeds seems to corresponds to the code of iw_devices, but this PR assumes the separator to be , ?

@alexAubin
Copy link
Member Author

@Thatoo : could you share the output of /sbin/iw dev | grep Interface ?

@Thatoo
Copy link
Contributor

Thatoo commented Jan 16, 2022

sure! Thank you Alex for taking some of your time to help me.

~ $ /sbin/iw dev | grep Interface
	Interface wlan1
	Interface wlan0

which seems to say that both devices are detected. If I disconnect the wireless usb dongle, only wlan0 remain.

However, when I go to hotspot settings, I don't have any choice, only one option with wlan1|wlan0 as explain in picture in here : #91

@Thatoo
Copy link
Contributor

Thatoo commented Jan 22, 2022

We should be careful about other places where iw_devices is invoked to be consistent:

 $ grep -nr iw_devices ./
./scripts/_common.sh:15:function iw_devices()
./scripts/config:30:    if [[ $(iw_devices) == "" ]]
./scripts/config:79:    if [[ $(iw_devices) == "" ]]
./scripts/config:86:        for device in $(iw_devices | sed "s/,/ /g")
./scripts/install:133:wifi_device=$(iw_devices | awk -F\| '{ print $1 }')
./scripts/restore:106:wifi_device=$(iw_devices | awk -F\| '{ print $1 }')
./scripts/upgrade:167:wifi_device=$(iw_devices | awk -F\| '{ print $1 }')

@zamentur : do you know why in install/restore/upgrade we seem to be using | as a separator (which indeeds seems to corresponds to the code of iw_devices, but this PR assumes the separator to be , ?

You're awesome @alexAubin !!!!! with | it works!
line 86 should not be changed from
for device in $(iw_devices)
to
for device in $(iw_devices | sed "s/,/ /g")
but to
for device in $(iw_devices | sed "s/|/ /g")

@ericgaspar
Copy link
Member

!testme

@yunohost-bot
Copy link
Contributor

🚀
Test Badge

manifest.json Outdated Show resolved Hide resolved
@alexAubin alexAubin merged commit 5fe1149 into master Jul 26, 2023
@alexAubin alexAubin mentioned this pull request Jul 26, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants