Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't check SMTP cert validity #177

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Don't check SMTP cert validity #177

merged 1 commit into from
Dec 8, 2023

Conversation

orhtej2
Copy link
Contributor

@orhtej2 orhtej2 commented Nov 23, 2023 •
edited
Loading

Problem

Solution

  • Disable SSL cert validation as the cert presented when connecting to 127.0.0.1 is issued to maindomain.tld.

PR Status

  • Code finished and ready to be reviewed/tested
  • The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

@orhtej2
Copy link
Contributor Author

orhtej2 commented Nov 23, 2023

!testme

@yunohost-bot
Copy link
Contributor

🌻
Test Badge

@orhtej2 orhtej2 mentioned this pull request Nov 23, 2023
Open
@nicofrand nicofrand merged commit 15586ab into YunoHost-Apps:testing Dec 8, 2023
@nicofrand
Copy link
Collaborator

Thanks! While waiting for a better solution re. certs management, I'll merge it!

@orhtej2 orhtej2 deleted the patch-1 branch December 8, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@orhtej2 @yunohost-bot @nicofrand