Enh config panel #37
Open
Enh config panel #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!testme |
|
😜 |
|
!gogogadgetotitus |
|
🤖 |
This was referenced Jun 11, 2022
…ynh into enh-config_panel
|
!gogogadgetotitus |
|
At your service! |
|
!gogogadgetotitus |
|
I am a benevolent CI! |
|
When will this be fixed because of trouble with #35? |
|
!testme |
|
🌻 |
|
Is somebody looking into this ? |
|
!testme |
|
May the CI gods be with you! |
|
!testme |
|
😜 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
If we don't choose the good type of redirection we need to reinstall the app.
In more it could be needed to change manually the nginx file if we want a proxy allowing frame or with a bigger client max body size.
Solution
Add a config panel to change the type of redirect and add extra features to manage client_max_body_size and frame_ancestors.
PR Status
Automatic tests
Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)