-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix upgrade #31
Fix upgrade #31
Conversation
Isn't this PR already included in #32? |
Huh, yes it is. |
So, as the other one will get merged, are you OK with closing this one? |
Yes, we can close this one as we merge the other one. |
Closing this PR as #32 got merged. |
I didn't understand, why merging this... or what did you mean by "close" . :-?? |
Well I actually closed it, but the two PR seem linked somehow (14 update branch was probably created from fix_upgrade branch), hence that surprising "JimboJoe merged commit 284b297 into testing ". |
Problem
Solution
PR Status
Work finished. Package_check, basic tests and upgrade from last version OK.
Could be reviewed and tested.
Validation
Minor decision
When the PR is mark as ready to merge, you have to wait for 3 days before really merge it.