Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix upgrade #31

Merged
merged 2 commits into from
May 8, 2018
Merged

Fix upgrade #31

merged 2 commits into from
May 8, 2018

Conversation

maniackcrudelis
Copy link

@maniackcrudelis maniackcrudelis commented Apr 24, 2018

Problem

  • Upgrade fails with error: "ImportError: No module named _internal"

Solution

  • Do not reinstall pip to avoid a conflict between pip versions.

PR Status

Work finished. Package_check, basic tests and upgrade from last version OK.
Could be reviewed and tested.

Validation


Minor decision

  • Upgrade previous version :
  • Code review :
  • Approval (LGTM) : Josué
  • Approval (LGTM) :
  • CI succeeded : Build Status
    When the PR is mark as ready to merge, you have to wait for 3 days before really merge it.

@maniackcrudelis maniackcrudelis requested a review from a team April 24, 2018 14:46
This was referenced Apr 24, 2018
@JimboJoe
Copy link

JimboJoe commented May 7, 2018

Isn't this PR already included in #32?

@maniackcrudelis
Copy link
Author

Huh, yes it is.
I probably cloned this PR to made the other one, in order to try the upgrade.

@JimboJoe
Copy link

JimboJoe commented May 7, 2018

So, as the other one will get merged, are you OK with closing this one?

@maniackcrudelis
Copy link
Author

Yes, we can close this one as we merge the other one.

@JimboJoe JimboJoe merged commit 284b297 into testing May 8, 2018
@JimboJoe
Copy link

JimboJoe commented May 8, 2018

Closing this PR as #32 got merged.

@frju365
Copy link
Member

frju365 commented May 8, 2018

I didn't understand, why merging this... or what did you mean by "close" . :-??

@JimboJoe
Copy link

JimboJoe commented May 8, 2018

Well I actually closed it, but the two PR seem linked somehow (14 update branch was probably created from fix_upgrade branch), hence that surprising "JimboJoe merged commit 284b297 into testing ".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants