Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working with ShaarliOS client (and maybe other apps ?) #39

Closed
mro opened this issue Apr 4, 2019 · 11 comments
Closed

Not working with ShaarliOS client (and maybe other apps ?) #39

mro opened this issue Apr 4, 2019 · 11 comments

Comments

@mro
Copy link

mro commented Apr 4, 2019

A user of my https://github.com/mro/ShaarliOS just has reported the same issue.

How's the situation with other clients like e.g. https://github.com/dimtion/Shaarlier ?

@mro
Copy link
Author

mro commented Apr 4, 2019

#13

@lapineige lapineige reopened this Apr 4, 2019
@lapineige
Copy link
Member

(sorry, misclick)

Please give the issue a proper name next time, this one isn't very eloquent :)

@lapineige lapineige changed the title #13 still an issue Not working with ShaarliOS client (and maybe some other apps ?) Apr 4, 2019
@lapineige lapineige changed the title Not working with ShaarliOS client (and maybe some other apps ?) Not working with ShaarliOS client (and maybe other apps ?) Apr 4, 2019
@lapineige
Copy link
Member

I don't know about Shaarlier.

How is you app working ? Where is it searching the API ?
Do you know precisely what's not working ?

@mro
Copy link
Author

mro commented Apr 4, 2019

I don't know about Shaarlier.

that's the client software mentioned in #13

How is you app working ?

Login fails because it can't find the login form inside the html (and needs it for CSRF tokens).

Where is it searching the API ?

/shaarli and is being redirected to /yunohost/sso/?r=...

Tomorrow I will ask my user who has the issue, if you may know the endpoint FQDN.

Do you know precisely what's not working ?

If both the https://github.com/mro/Shaarli-API-test/blob/master/tests/test-login-ok.sh and https://github.com/mro/Shaarli-API-test/blob/master/tests/test-post.sh complete successfully we're ok with the sunshine case.

Does that make sense?

Currently I'm redesigning the access and shall add a API facade that hides the shaarli peculiarities and exposes the pinboard/delicious API. https://github.com/mro/Shaarli-API-test/blob/develop/openapi.yaml – but this may take months to complete.

Essentially the yunohost SSO login seems to get in the way.

@lapineige
Copy link
Member

Is that shaarli instance public ? (accessible without the SSO)

@mro
Copy link
Author

mro commented Apr 4, 2019 via email

@lapineige
Copy link
Member

Well, I suppose it has to be public to use the API.
Or you could implement the SSO login support.
Or maybe just the API URL can be made accessible publicly - but I don't know what are the security issues. In particular, does it add a risk to compromise the password ? (as fail2ban is not activated right now for shaarli)

@anmol26s
Copy link
Contributor

anmol26s commented Apr 5, 2019

The app needs to be public. Otherwise you have to add the api link to public manually in /etc/ssowat/conf.json.persistent
by adding this line.
"skipped_urls": ["shaarli.domain.tld/api_link/"]

@anmol26s
Copy link
Contributor

anmol26s commented Apr 5, 2019

@lapineige
Fail2Ban support is there. Have you tested it? Is it failing?

@lapineige
Copy link
Member

As replied in #40, sorry, my bad, indeed it's implemented.
I did a basic test (trying wrong passwords using web interface), it works.

@mro
Copy link
Author

mro commented Apr 5, 2019

Thank you very much @lapineige and @anmol26s !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants