Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bookworm + portal rework #342

Merged
merged 31 commits into from
Oct 31, 2024
Merged

Bookworm + portal rework #342

merged 31 commits into from
Oct 31, 2024

Conversation

alexAubin
Copy link
Member

No description provided.

alexAubin and others added 19 commits May 4, 2023 22:38
Allowing login from simple HTML form
Also allow to pass username/password as two params instead of a combined "credentials"
Moulinette logging is an unecessarily complex mess, episode 57682
Tweaks and fixes for new portal API / ssowat refactoring
@selfhoster1312
Copy link
Contributor

selfhoster1312 commented Nov 3, 2023

I don't think a6c7e55 fixes YunoHost/issues#2238

The cookie should be deleted by the client but other copies of it (or if the client doesn't honor the request) remain valid for SSOWat... or did i miss something? So that's more like "delete cookies" than "logout" effectively, which i think is a security problem.

EDIT: This should have been fixed in the meantime

@selfhoster1312
Copy link
Contributor

I think all the building blocks are here to have a portal without javascript. I'll try and let you know. Thanks a lot!!!

@selfhoster1312
Copy link
Contributor

Soooo after messing around a little bit i realized we don't have the building blocks at all: yunohost-portal-api has no privileged API for a backend/daemon to know what permissions a user has, which was possible previously with /etc/ssowat/ssowat.json (although it was a hack and not intended). I opened #2433 to discuss it

@alexAubin alexAubin merged commit 62c0cf6 into dev Oct 31, 2024
1 of 2 checks passed
@alexAubin alexAubin deleted the bookworm branch October 31, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants