Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python linting in CI #79

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Add python linting in CI #79

wants to merge 12 commits into from

Conversation

Salamandar
Copy link
Contributor

No description provided.

@Psycojoker
Copy link
Member

We were kinda talking about maybe moving to ruff8 so I'm not sure this is the right direction '-'

Also I'm more in favor of automatic tooling doing the job in side than making merging PR harder since most of our contributors aren't professional developers in a professional context, I don't think we want to make contributing harder than it's already is :/

@Salamandar
Copy link
Contributor Author

You’re right, I’ll use ruff instead.

For your second point, i’m not sure i understand : this action is only checking, not committing or creating merge requests.

@Salamandar
Copy link
Contributor Author

@Psycojoker I reorganized the github actions in two:

  • one action only on push on master, that runs black+ ruff --fix (might be redundant), and commits
  • one action on push and pull request, that runs ruff (check only) and mypy, only for commit status, no commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants