Impl std error #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this contribution; I've just started the workflows. I didn't know about std::error::Error type so I never added it to any of my error types; night have to re-visit my other projects. |
|
All right these changes should now be on crates.io with version 0.4.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for the amazing crate!
This PR consists of two commits:
The first commit of the change implements
std::error::ErrorforErrortype so that it's easier for users to propagate the error returned bytime-tz.The second commit is a result of
cargo fmt, as I noticed there are some formatting issues like mixed tab-indentations and spaces-indentations.