Update syno-plex-update.sh #2
Conversation
- Updated ```PLEX_PREFERENCES_FILE``` for DSM 7 - Updated version comparison syntax
| if [ "${DSM_VERSION}" -ge "7" ]; then | ||
| PLEX_PREFERENCES_FILE='/var/packages/PlexMediaServer/shares/PlexMediaServer/AppData/Plex Media Server/Preferences.xml' |
There was a problem hiding this comment.
Nice! I wasn't aware of the symlinked path; this definitely looks cleaner than volume1
syno-plex-update.sh
Outdated
| PLEX_RELEASE_API='https://plex.tv/api/downloads/5.json?X-Plex-Token=TokenPlaceholder' | ||
| PLEX_RELEASE_API='https://plex.tv/api/downloads/5.json?channel=plexpass&X-Plex-Token=TokenPlaceholder' |
There was a problem hiding this comment.
What is the benefit of using channel=plexpass here? I'd expect that not all users (including myself) use the paid services, so we should make sure free Plex users aren't locked out from using the package due to downloading an exclusive version. Alternatively, this could also be a config option to suit both types of users.
There was a problem hiding this comment.
I think for free users, X-Plex-Token is not required. Yes. it should be made into an option either by a config file or passed in as parameter.
syno-plex-update.sh
Outdated
| if [ ! -z "${latest_version}" ] && [ "${latest_version}" != "${installed_version}" ]; then | ||
| set +eu | ||
| /usr/bin/dpkg --compare-versions "$latest_version" gt "$installed_version" | ||
| if [ "$?" -eq "0" ]; then | ||
| set -eu | ||
| write_log 'Update available. Trying to download and install' | ||
| notify_update_available | ||
| download_url=$(parse_download_url "${release_meta}") | ||
| download_and_install_package "${download_url}" | ||
| else | ||
| set -eu |
There was a problem hiding this comment.
Using dpkg comparison is a nice improvement 👍 This might look cleaner as a separate function that manages set (?)eu internally. Something like:
function is_latest_version_installed {
# Check that the installed version is at least as high as the available version.
local available_version=$1
local installed_version=$2
# dpkg version comparison uses exit codes so we'll tolerate errors temporarily.
set +eu
/usr/bin/dpkg --compare-versions "$available_version" gt "$installed_version"
local result="$?"
set -eu
echo ${result}
}Updated as suggested.
PLEX_PREFERENCES_FILEfor DSM 7