Remote deployments #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also now uses my fork to avoid generating network aliases when joining external proxy network. Without this, resolving a `postgress://db:5432` may lead to the wrong container being reached since multiple `db` aliases could have been generated.
YuukanOO
force-pushed
the
feat/multiple-providers
branch
from
2270657
to
5c89e57
Compare
YuukanOO
force-pushed
the
feat/multiple-providers
branch
from
5c89e57
to
e0c12e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one is HUGE.
It allows application to be deployed on remote targets, not just the local ones anymore.
For this to work and to prepare future developments, I had to change labels appended and project names to every resources created and so it introduces a breaking change. All containers already deployed will not be compatible.
Closes #9 #44 #1 #43