Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Use binary system to convert bytes to kbs and mbs #245

Merged
merged 1 commit into from
Sep 15, 2020

Conversation

AntoineGrandchamp
Copy link
Contributor

@AntoineGrandchamp AntoineGrandchamp commented Sep 15, 2020

Description

convertBytesToMbsOrKbs was using the decimal system to convert bytes to megabytes and kilobytes. I switched to binary system to match the actual file's size verification.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

  • Interactive docs testing

Test Configuration:

  • Browser: Firefox 80.0.1

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@panz3r panz3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@panz3r panz3r added the bug label Sep 15, 2020
@panz3r panz3r added this to the 3.5.0 milestone Sep 15, 2020
@panz3r panz3r merged commit 000764e into Yuvaleros:master Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants