Speed up by avoiding arguments and apply
#55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // This function accepts the same arguments as setImmediate, but | ||
| // returns a function that requires no arguments. | ||
| function partiallyApplied(handler) { | ||
| var args = [].slice.call(arguments, 1); |
There was a problem hiding this comment.
|
Benchmarks before and after, please. |
| } else { | ||
| var task = tasksByHandle[handle]; | ||
| if (task) { | ||
| currentlyRunningATask = true; | ||
| try { | ||
| task(); | ||
| run(task); |
There was a problem hiding this comment.
Separate function, outside of try finally for performance.
There was a problem hiding this comment.
ha fun fact from testing, try/finally is not an optimization killer...in v8, it is one in firefox
|
Benchmarks for the same case in Node.js are here; will add some for this instance as well. |
|
|
Awesome. Will merge and publish some time when I'm not at work. |
This was referenced Aug 15, 2016
|
|
||
| function setImmediate(callback) { | ||
| // Callback can either be a function or a string | ||
| if (typeof callback !== 'function') |
There was a problem hiding this comment.
curly braces around the body please
This avoids overhead with `arguments` and `apply`.
|
Updated code, passes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request avoids passing
argumentsaround, which is bad for performance. It also avoids unnecessaryapplycalls by optimizing for common numbers of parameters, as in Node.js.