Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP8.x community commits #2

Merged
merged 124 commits into from
Apr 6, 2023
Merged

Conversation

matidau
Copy link
Collaborator

@matidau matidau commented Apr 6, 2023

Bring all the working PHP8.x changes from the community to the main branch.

Sebastian Kummer and others added 30 commits July 8, 2019 22:11
* commit '91f1f05a7ca79ff51e3e667acd78457241b72cd9':
  ZP-1507 Fixed typos.
  ZP-1507 Send BackendFolderId to DeviceManager->GetFilterType() so we can lookup in global $specialSyncFilter (if available) if there is a limitation on the store, store/folderid (shortId) or store/backendid (longid).
  ZP-1508 Add default value to $categories parameter of ImportMessageReadFlag.
  ZP-1506 LOGLEVEL_WBXML does not work with ZLog::SpecialLogUser().
  ZP-1504 Add auth user to the IPC type for webservice calls.
  ZP-1503 Fix syntax error.
  imap.php edited online with Bitbucket
  ZP-1500 Clarified use of STARTTLS. Released under the Affero GNU General Public License (AGPL) version 3.
  ZP-1497 Don't add Everyone to memberOf.
  fix file paths and change function to public function. Released under the Affero GNU General Public License (AGPL) version 3.
  ZP-250 Set develop to WBXML loglevel.
  fix file paths and change function to public function
Released under the Affero GNU General Public License (AGPL) version 3.
* commit '27354b19e6657a4d590ffee6db52c1de5d260788':
  ZP-1514 Fixed include path for config.php. Fixed visibility of ContactWorker's Log and Terminate methods.
  ZP-1511 IMAP should use correct case for MIME-Version
  ZP-1510 Change man page section in debian packaging.
  ZP-1510 Change man page section in rpm packaging.
  ZP-1510 Change section in manpage files.
  ZP-1510 Rename man page files.
  ZP-1510 Install binaries in /usr/sbin in RPM builds.
* commit '5deb967fd15a2c2753e2da809264046308e579d0':
  ZP-1514 Fixed include path for config.php. Fixed visibility of ContactWorker's Log and Terminate methods.
  ZP-1511 IMAP should use correct case for MIME-Version
  ZP-1510 Change man page section in debian packaging.
  ZP-1510 Change man page section in rpm packaging.
  ZP-1510 Change section in manpage files.
  ZP-1510 Rename man page files.
  ZP-1510 Install binaries in /usr/sbin in RPM builds.
  ZP-250 Fixed logging level.
  ZP-1507 Fixed typos.
  ZP-1507 Send BackendFolderId to DeviceManager->GetFilterType() so we can lookup in global $specialSyncFilter (if available) if there is a limitation on the store, store/folderid (shortId) or store/backendid (longid).
  ZP-1508 Add default value to $categories parameter of ImportMessageReadFlag.
  ZP-1506 LOGLEVEL_WBXML does not work with ZLog::SpecialLogUser().
  ZP-1504 Add auth user to the IPC type for webservice calls.
  ZP-1503 Fix syntax error.
  imap.php edited online with Bitbucket
  ZP-1500 Clarified use of STARTTLS. Released under the Affero GNU General Public License (AGPL) version 3.
  ZP-1497 Don't add Everyone to memberOf.
  fix file paths and change function to public function. Released under the Affero GNU General Public License (AGPL) version 3.
  ZP-250 Set develop to WBXML loglevel.
  fix file paths and change function to public function
* commit '0b02fe87b129a46f16286c2a566d0ee41da5561a':
  ZP-1531 Use long-id if it's send when forwarding an email.
  ZP-1526 Don't add Everyone to memberOf on multi tenant systems.
  ZP-1524 Accepting meeting request on an ios device does not work.
  ZP-1519 Outlook feature doesn't work when 'mobile' feature is disabled.
  ZP-1515 Remove link to wincache issue.
  ZP-1515 Document possible IPC_PROVIDER values.
* commit 'bb272829b2c1642954e02fc143da2225dbe70032':
  ZP-1531 Use long-id if it's send when forwarding an email.
  ZP-1526 Don't add Everyone to memberOf on multi tenant systems.
  ZP-1524 Accepting meeting request on an ios device does not work.
  ZP-1519 Outlook feature doesn't work when 'mobile' feature is disabled.
  ZP-1515 Remove link to wincache issue.
  ZP-1515 Document possible IPC_PROVIDER values.
…d under the Affero GNU General Public License (AGPL) version 3.
…he Affero GNU General Public License (AGPL) version 3.
… under the Affero GNU General Public License (AGPL) version 3.
…leased under the Affero GNU General Public License (AGPL) version 3.
…me quotes. Released under the Affero GNU General Public License (AGPL) version 3.
…o GNU General Public License (AGPL) version 3.
… too. Released under the Affero GNU General Public License (AGPL) version 3.
…tion according to MS-OXCICAL in _ParseASEventToVEvent(). Released under the Affero GNU General Public License (AGPL) version 3.
…ToSyncObject(). Released under the Affero GNU General Public License (AGPL) version 3.
…ewtimeproposal properly. Released under the Affero GNU General Public License (AGPL) version 3.
… remove X-MICROSOFT-DISALLOW-COUNTER property. Released under the Affero GNU General Public License (AGPL) version 3.
…Released under the Affero GNU General Public License (AGPL) version 3.
…ased under the Affero GNU General Public License (AGPL) version 3.
…-ASTASK. Released under the Affero GNU General Public License (AGPL) version 3.
… DESCRIPTION property in _ParseVTodoToSyncObject(). Released under the Affero GNU General Public License (AGPL) version 3.
…er the Affero GNU General Public License (AGPL) version 3.
Released under the Affero GNU General Public License (AGPL) version 3.
* commit '853f88505955940aa7c701152ee51a8feeb36681':
  ZP-1578 Remove fixstates-upgrade from z-push-admin.
  ZP-1577 iCalendar: replace dbg_error_log() with ZLog::Write(). Released under the Affero GNU General Public License (AGPL) version 3.
  ZP-1578 Remove executing fixstates on upgrade.
…ersion using "//IGNORE" option. Released under the Affero GNU General Public License (AGPL) version 3.
…ould return "(unknown)" as string and replace "%a" with "%d", because "%a" does not work on DateIntervals. Only use negative DateIntervals with reminder (number of minutes before calendar item start). Released under the Affero GNU General Public License (AGPL) version 3.
* commit 'aef85e0ea5137368720fb9b7802b6c134ff29965':
  ZP-1583 Don't expose Z-Push version in PrintZPushLegal.
* commit '3dead535bcbdfdae2624aef975d23418b681df3d': (75 commits)
  ZP-1583 Don't expose Z-Push version in PrintZPushLegal.
  ZP-1578 Remove fixstates-upgrade from z-push-admin.
  ZP-1577 iCalendar: replace dbg_error_log() with ZLog::Write(). Released under the Affero GNU General Public License (AGPL) version 3.
  ZP-1578 Remove executing fixstates on upgrade.
  ZP-250 Fixed logging level in release/2.6 branch.
  ZP-1513 Added comment regarding USE_CUSTOM_REMOTE_IP_HEADER.
  ZP-1570 BackendIMAP: unset variables earlier. Released under the Affero GNU General Public License (AGPL) version 3.
  ZP-1573 fix uninitialized string offset warnings.
  ZP-1572 Atendees fuplicated in  meetings.
  ZP-1570 BackendIMAP: log complete headers and body each with one ZLog::Write() call. Released under the Affero GNU General Public License (AGPL) version 3.
  ZP-1570 BackendIMAP: Further changes to limit logging within SendMail() method to about 10 KB and let ZLog::Write() truncate log. Released under the Affero GNU General Public License (AGPL) version 3.
  ZP-1570 BackendIMAP: limit log to about 10 KB and let ZLog::Write() truncate log. Released under the Affero GNU General Public License (AGPL) version 3.
  ZP-1539 Limit contact picture size in gab-sync.
  ZP-1570 BackendIMAP: reduce memory usage for logging. Released under the Affero GNU General Public License (AGPL) version 3.
  ZP-1568: remove required XMLElement.php (only used in deprecated functions, which are already removed - see: https://stash.z-hub.io/projects/ZP/repos/z-push/commits/a3faa229cae23108a41a3eb1f5f89ed31028a7dc). Released under the Affero GNU General Public License (AGPL) version 3.
  ZP-1568: fix masking of confidential event components (see: https://gitlab.com/davical-project/awl/-/commit/d60c4286b2ed8a082a2f93ee1a4335d4779a5bde). Released under the Affero GNU General Public License (AGPL) version 3.
  ZP-1568: Remove deprecated description (see: https://gitlab.com/davical-project/awl/-/commit/c4493a7e805bffa0e9b7c1fddc461e3bf8141397). Released under the Affero GNU General Public License (AGPL) version 3.
  ZP-1568: correct replacement (see https://gitlab.com/davical-project/awl/-/commit/b25ba1b56f03a973b42c5f3cd53f1c88a917d13d). Released under the Affero GNU General Public License (AGPL) version 3.
  ZP-1568: Fix parsing of quoted iCal properties/values in ParseFrom() (see: https://gitlab.com/davical-project/awl/-/commit/2377d92cc199472b0a039d10dd007892fed9c897). Released under the Affero GNU General Public License (AGPL) version 3.
  ZP-1568: Remove deprecated class iCalendar. Released under the Affero GNU General Public License (AGPL) version 3.
  ...
…etection and correction on encoding errors. Released under the Affero GNU General Public License (AGPL) version 3.
* commit 'd8d568a65f0c0a1a9c735651d6c569410abbecf6':
  ZP-1593 BackendIMAP: fix return value of GetMailboxSearchResults(). Released under the Affero GNU General Public License (AGPL) version 3.
  ZP-1584 Autodiscover return 400 http code for unsupported schema.
  ZP-1591 Hard delete messages after move.
  ZP-1590 Save organiser email address.
  ZP-1589 Fix null array offset warnings.
  ZP-1586 Unset deleted properties in gab2contacts.
  ZP-1581 BackendIMAP: use Z-Push definitions. Released under the Affero GNU General Public License (AGPL) version 3.
  ZP-1581 BackendIMAP: remove redundant comparison. Released under the Affero GNU General Public License (AGPL) version 3.
  ZP-1582 BackendIMAP: use "Importance" header (RFC4021). Released under the Affero GNU General Public License (AGPL) version 3.
  ZP-1581 BackendIMAP: implement answered and forwarded states. Released under the Affero GNU General Public License (AGPL) version 3.
  ZP-1581 BackendDiff: add states for answered and forwarded flag. Released under the Affero GNU General Public License (AGPL) version 3.
umgfoin and others added 23 commits June 30, 2022 18:49
Signed-off-by: umgfoin <umgfoin@users.noreply.github.com>
Signed-off-by: umgfoin <umgfoin@users.noreply.github.com>
Signed-off-by: umgfoin <umgfoin@users.noreply.github.com>
…ased under the Affero GNU General Public License (AGPL) version 3.
… to recipients array. Released under the Affero GNU General Public License (AGPL) version 3.
Signed-off-by: umgfoin <umgfoin@users.noreply.github.com>
Signed-off-by: umgfoin <umgfoin@users.noreply.github.com>
This was removed from z-push several years ago with the switch to changesink and the kopano backend. It introduced a bug in the IMAP backend where changes were not always detected with changesink and new messages are not pushed to mobile until more than one new message arrives. Reverting to the timer method may be too resource intensive on large deployments but it was the best workaround short of new IMAP code to better utilize changesink. There was some discussion in the now defunct z-hub jira.
…he supplied encoding is invalid

Some emails seem to arrive with an invalid or no encoding type. in PHP 7 mbstring just failed silently. In PHP 8 ValueError is thrown which breaks sync with a fatal error. ValueError is new for PHP 8 so we can't just catch that.
PHP8.x related errors where null $address passed to functions expecting a string.

Tested on MIAB and Nine email client on Android.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants