Use more generic linux-x64 for NuGet rid. #5310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| 'ubuntu-18' : ('so', 'ubuntu-x64'), | ||
| 'ubuntu-20' : ('so', 'ubuntu-x64'), | ||
| 'glibc-2.31' : ('so', 'ubuntu-x64'), | ||
| os_info = {"z64-ubuntu-14" : ('so', 'linux-x64'), |
There was a problem hiding this comment.
ubuntu-14 is probably long gone and I will remove on next occasion.
I use either 18 or default 20 these days. I understood there are some incompatibilities with 20 on downlevel platforms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The more generic 'linux-x64' should be used as the linux rid for NuGet packages, because at the moment only 'ubuntu-x64' is included in the package. Therefore, loading in dotnet on e.g. 'debian-x64' does not work, even though there seems to be no fundamental reason it should not. As a minimal test, manually changing the rid and the associated directory path in the build output to 'linux-x64' makes everything work as expected on 'debian-x64'.
It does not appear that different shared objects (per specific distribution) are being produced anyway, so this change should have no regressions, as far as I understand it. At the very least, the rid should be changed to 'debian-x64' since this is a parent of 'ubuntu-x64' in the hierarchy, but I don't see any reason not to go to the further ancestor 'linux-x64'.