Implement reflection cache for unions, tuples, options and maps #254
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Zaid! I recently identified a performance issue when serializing one of our F# domain models. The performance issue was caused by many repeated reflection calls at runtime in the FableConverter.
The "worst case" seems to be large DUs as keys in a Map, with many items in the Map. Our model looks something like this:
I've made some performance improvements which basically boil down to:
For our domain model (basically the code structure mentioned above) we saw serialization time decrease from
450ms
to1.5ms
, which we're pretty happy with!