Tasks #323
Merged
Tasks #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @kerams sorry for taking this long to look into this PR, it looks great! I will merge and try to deal with the failing tests but all in all, we should get this out there 😄 |
|
Fixed the tests and published a batch of packages 🚀 should be up as soon as nuget finishes indexing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #134. Supersedes #293.
Bumped required FSharp.Core for the server bits to 6.0, so that the internals can be Task-based for extra performance. Just like in #293, Task endpoints are supported, but still cannot be consumed in Fable without the type spoof hack.
DotnetClient has been updated and supports Task endpoints. There are also additional methods on the Proxy type that return Task instead of Async:
let! result = proxy.callTask (fun server -> server.pureAsync).The test failure comes down to the fact that 3 UI test projects reference FSharp.Core via the Main and Client dependency groups, and because of the lowest_matching constraint both version are different. Not sure how to solve this.