Add new check: matches_regex #39
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZaxR
reviewed
Jul 29, 2019
| @@ -408,6 +408,35 @@ def is_same_as(df, df_to_compare, **kwargs): | |||
| return df | |||
|
|
|||
|
|
|||
| def matches_regex(df, pattern, columns=None, **kwargs): | |||
There was a problem hiding this comment.
What do you think of passing a dictionary of pattern: columns, so that different columns can be checked for different patterns in the same check? Otherwise you might have to call this check a number of times. Trying to balance the simplest possible interface with the most flexibility
|
Thank you so much the the PR! I just added a comment when you get a chance to take a look. So excited to get this functionality merged :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #19
Uses
pandas.Series.str.match, and allowskwargsto be passed through to that call (case,flags,na).