Improve support for integer values #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the given argument is not an integer, the value will not be encoded and the overall encoding becomes invalid because a value is missing. It is better to throw rather than silently failing.
|
It is arguable whether we want to automatically truncate the values like in some other cases, but I think it is better to notify the user that something is wrong rather than automagically trying to fix the value. Maybe we should also update the documentation to specify that failing to meet this requirement will throw. |
|
Hey @Zazama do you mind having a look at this PR? Thanks. |
|
Sounds reasonable, kind of interesting to learn that there is no normal int type in js. I think the documentation is clear like this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation does not specify that the
timeStampvalues must be an integer.When the values are not an integer the
appendNumberfunction silently omit to write the value and creates an invalid encoded buffer.timeStampmust be a positive integerappendNumberfunction to throw aRangeErrorwhen the given value is not an integer instead of creating an invalid bufferfixes #146