Remove pub from fields, add getters #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #401 +/- ##
==========================================
+ Coverage 69.81% 70.65% +0.84%
==========================================
Files 30 30
Lines 2650 2614 -36
==========================================
- Hits 1850 1847 -3
+ Misses 800 767 -33
☔ View full report in Codecov by Sentry. |
Merged
Merged
natalieesk
reviewed
Jun 23, 2023
natalieesk
requested changes
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #398
This removes
pubfrom fields and adds getters instead, which combined with thenew()methods from #398 allow recreating structs, which in turn allows using arbitrary encoding schemes.This also adds tests for them.
The sample-values-building functions introduced in those tests will be backported to the serde tests, allowing creating ciphersuite-generic tests.
Finally this switches to
BTreeMapfor signing commitments, which I had to touch anyway to introduce a getter for it and IMO makes the code a lot of simpler. (This was also done in #397 )