-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
export and test new precompute API #16
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d94fe7678 zcash_script: Add API to verify scripts with precomputed tx data 2178e309d Rename libzcashconsensus.la -> libzcash_script.la 515b37aa2 Rename zcashconsensus_* -> zcash_script_* in APIs 021e8050d Rename src/script/zcashconsensus.* -> src/script/zcash_script.* 06d6b7d8b Add amount and consensus branch ID to zcashconsensus_verify_script 1f3b27427 Remove crypto/equihash from libzcashconsensus dc8ac9107 prevector: Terminate without logging on failed allocation 1075096bb Remove init_and_check_sodium from crypto/common.h 09e423ccc Remove JSDescription::h_sig bc2f687ca Add JSDescriptionInfo for constructing JSDescriptions 28c01c2b5 Default to defining endian-conversion DECLs in compat w/o config bd1166814 Replace boost::optional with std::optional 04bd26523 Replace boost::variant with std::variant 43ab084 Auto merge of #4611 - str4d:c++17, r=str4d d0cb0b7 Switch from std::random_shuffle to std::shuffle c656ae1 Add new copyright entries for build-aux/m4/ax_cxx_compile_stdcxx.m4 9052751 depends: Build C++ dependencies with C++ 17 9d1a11a build: Require and build with C++ 17 40a5bdf build: Update AX_CXX_COMPILE_STDCXX macro de5c28b Auto merge of #4613 - str4d:claaaaaang, r=daira 8fa19fd Auto merge of #4794 - LarryRuane:allow-getaddressutxos, r=daira 0dc05a7 Auto merge of #4790 - therealyingtong:add-addresses-getblocksubsidy, r=daira eaed8d5 depends: Add untested note to FreeBSD host 162de8b Auto merge of #4800 - daira:contextualchecktx-cleanups, r=str4d 083a05b allow getaddressutxos if -lightwalletd 0940bc0 Remove void declaration of ScriptPubKeyToJSON() 2d2dc2c Auto merge of #4799 - daira:fix-gtests-displayduration, r=str4d 72a0107 Comment and error message cleanups for transaction checks. f2d7fd6 contrib/devtools/symbol-check.py: add info about Fedora-based distributions. d54d4d0 Update contrib/devtools/symbol-check.py e0b3913 Rename `time` to `duration` in `DisplayDuration`. a6822ed Fix integer types in DisplayDuration. 6f3c29e Only return address instead of CScript 921e886 Auto merge of #4797 - daira:log2-cleanup, r=str4d 7a1ed86 log(x)/log(2.0) can be written as log2(x). e60c2bf Apply suggestions from code review 1c91003 Auto merge of #4787 - benzcash:ci-builders-libtinfo5, r=str4d 4e50b70 Minor cleanups 719c117 Handle shielded address case 6c41d1d Fix CScript encoding ceb6425 Auto merge of #4789 - daira:4785-macos-tests, r=str4d cec67e9 Add funding stream addresses to getblocksubsidy RPC output 98daea8 Auto merge of #4791 - str4d:pyflakes-fixes, r=str4d 11baa4d doc: Add Clang and libc++ migration to release notes ee079a6 test: Fix various pyflakes warnings ea7d57a QA: Add native_clang and libcxx to updatecheck.py c06cc58 qa/zcash/full_test_suite.py: print immediately if a test fails. f85ed27 qa/zcash/full_test_suite.py: changes needed for macOS. fixes #4785 172b269 Build python for debian9 and ubuntu16.04 c6f9215 Fixed Centos and Arch python requirements 1271afa Added Arch and Centos to script, added libtinfo5 for arch bf450b2 qa: Disable FORTIFY_SOURCE checks 03e68a3 Auto merge of #4782 - oxarbitrage:issue4769, r=str4d b598691 Added libtinfo5 to ci builder containers 52270f6 update function comment 5bd2df9 Auto merge of #4784 - LarryRuane:auto-GetConsensus, r=str4d ea4c665 simplify TestBlockValidity fb24911 Auto merge of #4570 - oxarbitrage:issue2783, r=daira fbf2743 performance: auto params = CChainParams::GetConsensus() 5a1e685 build: Add -lpthread to univalue test LDFLAGS e917cb6 build: Compile secp256k1 with C99 ab4033c depends: Fix boost::iostreams usage on Windows with libc++ c691a84 depends: Rename Boost libraries to follow MinGW/GCC convention b076c8d Auto merge of #4770 - nuttycom:fastsync, r=nuttycom c6abcc4 Use the current time as the timestamp if we override a misc warning. a75c613 Fix command-line help for -ibdskiptxverification 3973a16 depends: Fix "unused variables" warning when compiling zeromq for Windows 2ca72ad build: Add missing LIBUNIVALUE to Makefile.bench.include LDADD 5ca4fbf build: Statically link libc++ fa54a16 depends: Add multilib paths for Linux cross-compile 0887f64 depends: Don't replace default CXXFLAGS in C++ dependencies 1b96347 depends: Add libc++ as a dependency 95e3823 Rename IBDSkipTxVerification back to ShouldCheckTransaction acfa675 Auto merge of #4778 - daira:no-nazis, r=daira ff4cb00 depends: Vendor LLD and use it for linking 4abd76f depends: Use vendored Clang for macOS cross-compilation d3330ab Fix warnings surfaced by compiling with clang++. d306b72 depends: Use vendored Clang for native compilation d071e31 depends: Add Clang 8.0.0 48d975f Auto merge of #4775 - str4d:postpone-rustc-updates, r=str4d a2f8519 Auto merge of #4779 - nathan-at-least:static-patchfile-bdb, r=str4d 5a47aa5 Convert a sed command to a static patch file. 3c8ce84 Auto merge of #4777 - daira:fix-bind-warning, r=str4d 60164a1 Beef up the CoC to address use of dog-whistles. acf2d07 Fix a new warning about use of boost::bind placeholders after updating Boost. closes #4774 88a7dd5 Reject incompatible flags in "Step 2" 8a2aaeb Ensure conflicting flags are reported as an error. 2c051ac Apply suggestions from code review ebc8de3 Auto merge of #4776 - str4d:logging-files, r=str4d f0c24bd -ibdskiptxverification must imply -checkpoints b425823 MOVEONLY: Move logging code from util.{h,cpp} to new files 293af68 Apply style suggestions from code review cd68450 depends: Postpone current and scheduled Rust releases until 2021 e2d3533 Auto merge of #4773 - str4d:4651-combined-params-init, r=daira ce26c21 Auto merge of #4772 - daira:log-invalid-notept, r=daira 9117240 Reduce diff complexity. 508aadd FFI: Merge librustzcash_init_zksnark_params variants into one function 6e4090d Auto merge of #4766 - str4d:update-zeromq, r=str4d 007de07 Add logging when we receive an invalid note plaintext (using the "receiveunsafe" log category). a5c2daf depends: Update packages documentation for Zcash fd841a1 Remove redundant CheckBlock calls. 0b4395d Add a config option to skip transaction verification in IBD mode 7c9fa28 depends: ZeroMQ 4.3.3 3c4f9d3 build: pass --enable-option-checking to applicable packages 3420f01 build: only pass --disable-dependency-tracking to packages that understand it 13f0e78 depends: zeromq: disable draft classes and methods 84dfe68 depends: Purge libtool archives df60fd9 depends: Build secondary deps statically. edfb4d9 [depends, zmq, doc] avoid deprecated zeromq api functions 92aa4d6 depends: Disable unused ZeroMQ features b646bad Auto merge of #4765 - str4d:more-depends-updates, r=str4d b56e5aa cargo update be700a8 depends: ccache 3.7.12 a9f62bd depends: Boost 1.74.0 4705aae Auto merge of #4763 - rex4539:remove-bitcoin-release-notes, r=str4d d3978db Auto merge of #4762 - rex4539:remove-deprecated-init, r=str4d c84ae00 Remove Bitcoin release notes 1fa5d46 Remove deprecated init.md b667bfa Auto merge of #4760 - rex4539:fix-zeromq-warning, r=daira 95a5c30 Fix zeromq warning ce44f60 Auto merge of #4758 - str4d:depends-updates, r=str4d eb4c9ea Auto merge of #4484 - defuse:fix-undefined-behavior-in-bitcoin-test, r=str4d 3693b96 Fix undefined behavior in the test_bitcoin tests a983344 Auto merge of #4752 - str4d:small-httpserver-backports, r=daira 2fbc111 httpserver: Code style cleanups e15eaf0 QA: Fix backporting bugs in httpbasics.py 939c5df Auto merge of #4756 - str4d:4755-exorcise-openssl, r=str4d 0d4a7b0 depends: Use correct HOST for download-linux target 076c1af depends: utfcpp 3.1.2 78a7230 depends: googletest 1.8.1 7725f66 depends: ccache 3.7.11 96da9c2 depends: libevent 2.1.12 be7876a build: Remove a stray -lcrypto b5fa52b Auto merge of #4740 - str4d:remove-openssl, r=daira ce0654e Cosmetics in CScriptNum code and tests. 932d627 It's unnecessary to pass int64_t by const reference. f432fe5 Add assertions for CScriptNum[10] +/- int64_t to avoid the possibility of UB. 9ba10a8 Avoid undefined behaviour in scriptnum tests. 860e6e6 httpserver: replace boost threads with std 97194f2 httpserver: use a future rather than relying on boost's try_join_for 26efd3a http: use std::move to move HTTPRequest into HTTPWorkItem a500df5 http: Change boost::scoped_ptr to std::unique_ptr in HTTPRequest 1f106fa http: Add log message when work queue is full fc9ce9e http: Do a pending c++11 simplification b165ead Minor additional OpenSSL scouring. bab8537 QA: Remove OpenSSL from updatecheck.py ab35a26 Remove remaining OpenSSL references ce1b549 util: Remove OpenSSL multithreading infrastructure fe49dc5 build: remove libcrypto as internal dependency in libbitcoinconsensus.pc 4526ecf doc: remove OpenSSL from build instructions and licensing info f477932 depends: remove OpenSSL package 0ad49bc build: remove OpenSSL detection and libs 8993f1f build: remove SSL lib detection c28c9b9 tests: Remove OldSetKeyFromPassphrase/OldEncrypt/OldDecrypt 7b3cb48 Replace scriptnum_test's normative ScriptNum implementation 220e166 Move uiInterface.NotifyBlockTip signal above the core/wallet signal 66515b0 NotifyBlockTip signal: switch from hash (uint256) to CBlockIndex* 23556e6 http: Restrict maximum size of request line + headers 7d94064 Auto merge of #4643 - str4d:locked-memory-manager, r=str4d 9245388 Auto merge of #4749 - str4d:update-config-guess-and-sub, r=str4d 94cf4a4 Auto merge of #4558 - linuxion:master, r=str4d abcce56 [RPC] Add transaction size to JSON output f43e383 gitian: Switch from x86_64-unknown-linux-gnu to x86_64-linux-gnu bd87bcf build: Switch to x86_64-pc-linux-gnu for codecov filtering f52793d QA: Switch to x86_64-pc-linux-gnu for hard-coded Linux HOST 9384b78 depends: Update map of GCC canonical hosts to Rust targets 55acaf4 allocators: Apply Allocator named requirements to secure_allocator::deallocate 66ac442 LockedPool: Make Arena::free and LockedPool::free noexcept fa6921c LockedPool: Fix LockedPool::free(nullptr) to be a no-op b2b5ccc test: Fix LFSR period in comments b5ddac4 LockedPool: Switch to HTTPS URLs in licenses and comments 514d868 Auto merge of #4739 - str4d:update-leveldb, r=str4d f4c78c4 leveldb: Fix typo e2eeabe Update license headers f558267 leveldb: Assert that ssize_t is the same size as size_t on Windows 3d79da1 build: out-of-tree fixups a3fbfe4 Improve readability by removing redundant casts to same type (on all platforms) 94f7ae6 Fix subscript[0] potential bugs in key.cpp e886263 Auto merge of #4748 - rex4539:fix-typos, r=daira 8e55824 depends: Update to latest config.guess & config.sub d8ab284 Auto merge of #4747 - rex4539:fix-cargo-checksum, r=str4d 67ffb18 Fix typos 4e1d385 Remove reference to cargo-checksum.sh 8f15f5f Auto merge of #4734 - str4d:2-sodium-2-oxide, r=str4d 9ef15a8 Auto merge of #4746 - str4d:remove-rust-mingw-workaround, r=ebfull 256d6e3 Auto merge of #4743 - str4d:cargo-vendor-cleanups, r=str4d 7169cfc build: Remove Rust staticlib naming workaround 0f3baab tracing: Correctly override tracing::Span move constructors 02b7d2a blake2b: Allow consuming partial BLAKE2b output 2d172e1 Replace libsodium's crypto_generichash_blake2b with blake2b_simd 31f48ca Auto merge of #4690 - LarryRuane:CopyPreviousWitnessesPart2, r=str4d ad56e9c Auto merge of #4693 - daira:explicit-coercions, r=str4d a554f7c depends: Remove cargo-checksum.sh 49fc20a Auto merge of #4720 - ebfull:fix-perf-regressions, r=str4d f3e5adc Pull leveldb subtree dd6b342 Squashed 'src/leveldb/' changes from 524b7e36a..f545dfabf cd819bf Merge leveldb subtree 55f9091 Squashed 'src/leveldb/' changes from 64052c76c..524b7e36a 7474d2c Bump leveldb subtree b3f8c6e Squashed 'src/leveldb/' changes from c521b3ac6..64052c76c 990c6d2 Update LevelDB with latest Bitcoin-specific patches b3b77fb Squashed 'src/leveldb/' changes from 196962ff0..c521b3ac6 55b4aa1 build: verify that the assembler can handle crc32 functions b892fe1 Fixed multiple typos f204f57 Add extra LevelDB source to Makefile f261701 leveldb: enable runtime-detected crc32 instructions c333e99 Update to LevelDB 1.20 f67e496 Squashed 'src/leveldb/' changes from a31c8aa40..196962ff0 8dbec77 Merge in LevelDB 1.19 changes b4be084 Squashed 'src/leveldb/' changes from 20ca81f08..a31c8aa40 1e66c82 Do not include env_win.cc on non-Windows systems 7bf4f0b Add MIT license to Makefiles 9cc7497 build: out-of-tree fixups a0336af build: No need to check for leveldb atomics 58d1bbf leveldb: integrate leveldb into our buildsystem 52777e6 Update to latest zcash_* and zkcrypto crates. 16e91b0 cargo update 03ce240 Update Rust to 1.44.1. c9672a4 Auto merge of #4696 - str4d:3640-z_sendmany-any-taddr, r=str4d 3311a85 rpc: Fix comma spacing in example z_sendmany commands e33f530 wallet: Ignore coinbase UTXOs with z_sendmany ANY_TADDR 8dcab5e Auto merge of #4737 - nathan-at-least:link-to-read-the-docs-build-instructions, r=daira fbca35e Line-wrap addition to README.md 933e841 Link the README.md to the specific readthedocs.io page for building on Debian/Ubuntu. 35bb61b Auto merge of #4725 - str4d:cargo-vendor, r=str4d 2449349 depends: Ensure that SOURCES_PATH exists before vendoring crates c36ad21 QA: Comment out Rust crate checks in updatecheck.py 549bf2d depends: Switch to `cargo vendor` for Rust dependencies b8650d6 Auto merge of #4732 - zcash:3786_review_dependencies, r=str4d 0314ad1 Postponed dependency updates, refer to core team sync meeting. 6f9b281 Auto merge of #4706 - str4d:4705-nuparams-config-file, r=daira 81db0a2 Flush witness data when consistent (part 2) 566e0d3 Allow multiple nuparams options in config file f8e1a02 Auto merge of #4561 - oxarbitrage:issue1873, r=daira fbe6891 Ensure that the absolute path used in the test definitely does not exist. 21fee30 Fix grammar in error messages. dc9c95b Apply suggestions from code review 6a7cfde allow wallet file to be outside datadir 7e958be Auto merge of #4300 - oxarbitrage:issue3939, r=nuttycom 9d8555c Fix forward declaration. 4439545 Auto merge of #4687 - defuse:fix-cscript-test-buffer-overflows, r=daira af6ca14 Auto merge of #4357 - oxarbitrage:issue2880, r=daira cf8cd09 Auto merge of #4349 - oxarbitrage:issue3996, r=daira 3caa784 Auto merge of #2778 - syd0:add-python-assert, r=daira bd44693 Rename z_*_balance fields of getwalletinfo output to shielded_*_balance 4c4a1c4 Revert the move of the `getBalanceZaddr` block for ease of review. 48149de Prevent creation of shielded transactions in initial block download. ef62a1c Auto merge of #4688 - defuse:fix-rpc-test-string-interpolation, r=daira 5e7e968 Auto merge of #4702 - ebfull:release-v4.0.0, r=ebfull 02c5f08 minor: Add backticks to avoid formatting in 4.0.0 release notes. 505495a make-release.py: Updated release notes and changelog for 4.0.0. eedd285 make-release.py: Updated manpages for 4.0.0. 01d1ea5 make-release.py: Versioning changes for 4.0.0. 539e487 Postpone updates for dependencies until after 4.0.0 release. 6937dff Set activation height for Canopy on mainnet. 5f398da Auto merge of #4700 - zcash:df-addrs, r=daira 889b05d Clarify a comment about the ZF and MG addresses abd4b73 Add dev fund addresses for mainnet. 06d4439 wallet: Add ANY_TADDR special string to z_sendmany 75f9f8f Make some conversions explicit to reduce sanitizer warnings. 4003b59 Auto merge of #4686 - ebfull:release-v4.0.0-rc1, r=ebfull c0f50ef Specify 4.0.0 in release notes 5a56246 Update names of contributors in release notes. 51b9e23 Add a missing % to a string interpolation in rpc test framework 9f284b5 Fix buffer overflows in P2PKH tests af36cea Add release notes to describe the Canopy network upgrade. 95d159c make-release.py: Updated release notes and changelog for 4.0.0-rc1. 4ce87e9 make-release.py: Updated manpages for 4.0.0-rc1. a5d6dbd make-release.py: Versioning changes for 4.0.0-rc1. 104cc4d Postpone rust updates 651721d Postpone boost 1.74.0 update 16c99c2 Auto merge of #4685 - LarryRuane:wallet-locking, r=ebfull fb8dd9d CBufferedFile: use eof() method rather than feof(src) in error message. 6c20de2 CBufferedFile: assert that Fill() is only called when nReadPos == nSrcPos, and simplify based on that assumption. 8686910 Add null check to feof. b941974 Auto merge of #4313 - zancas:4312_define_EXPECTED_BLOCKS_PER_HOUR, r=daira d3acf75 Auto merge of #4542 - nuttycom:reorder_checks, r=nuttycom bff5476 Add comment in lieu of redundant overwinter version check & fix tests. 494f034 Auto merge of #4682 - str4d:rust-crate-updates, r=str4d 3261ba4 wallet: lock cs_main while accessing chainActive 6c1204b FFI: Rename r to rcm fbe54c4 FFI: Rename to librustzcash_sapling_compute_cmu 0ac2261 qa: Update list of postponed crate versions f0babb8 depends: cargo update bb1e1e5 FFI: Migrate to bls12_381 and jubjub crates 3fd4094 FFI: Remove circuit parameter hashes from librustzcash_init_zksnark_params c10ba7d depends: Migrate to zcash_* 0.3.0 Rust crates 35961c4 add shielded balance to getwalletinfo 9dca208 make deprecation.h include consensus/params.h b464b7d Auto merge of #4678 - str4d:zip-215-more-test-cases, r=str4d 4089e76 consensus: Remove redundant contextual consensus rules 56de0a0 consensus: Reorder Overwinter+!Sapling rules 8927452 consensus: Move Sapling-disabled Overwinter rules above Sapling rules 8175dc5 consensus: Combine saplingActive conditionals 50afda0 consensus: Move overwinterActive rules ahead of saplingActive rules 25974d4 consensus: Add a placeholder for !canopyActive 830b8a4 consensus: Combine heartwoodActive conditionals 6027a61 consensus: Remove canopyActive gate around GetActiveFundingStreamElements 570478a consensus: Refactor Sprout contextual rules to match the rest cf45a26 consensus: Clean up some whitespace and variable names a379f27 test: Update ZIP 215 test cases from ed25519-zebra 595b15f Auto merge of #4675 - str4d:zip-207-ncc-comments, r=nuttycom 732f1a7 Adjust GetActiveFundingStream* comments 30619ae Auto merge of #4654 - str4d:sodium-oxide, r=str4d d41cf37 ed25519: Panic (triggering abort) if nullptr passed into APIs efb4246 Replace libsodium's crypto_sign with ed25519-zebra c595056 consensus: Clearly gate active funding stream elements on Canopy 016e351 Auto merge of #4674 - therealyingtong:zip-212-ncc-fixes, r=therealyingtong 1ed936b Add link to ZIP212 in coinbase comment 768534a consensus: Statically check funding stream numerators and denominators bfeaa0e consensus: Document the empty conditional branch in ContextualCheckBlock b47f686 consensus: Add assertions for Params::HalvingHeight parameters 2f2c8ea Rename PRV_DIVERSIFIER to PRF_TAG c3f0e18 Auto merge of #4672 - charlieok:remove_debian_8_jessie_descriptor, r=str4d edcecc8 assert(leadbyte == 0x02) after every if(leadbyte != 0x01) 952c7f7 Define PRF diversifiers in prf.h 992007e Move esk derivation check to beginning of plaintext_checks_without_height() 2361228 Add documentation specific to ZIP 212 1c447d8 Replace libsodium's randombytes_buf with rand_core::OsRng::fill_bytes 2605fc2 Remove 'jessie' (debian 8) from suites list in linux gitian descriptors 24863f3 Auto merge of #4619 - nuttycom:bazel-patches, r=daira 940fe0b Auto merge of #4657 - str4d:tracing-fields, r=str4d 5ca852b debian: Rename X11 to Expat-with-advertising-clause in copyright c2f991d Auto merge of #4659 - str4d:tracing-init, r=str4d 70b8aac Auto merge of #4670 - daira:update-checksec, r=str4d 0cdce26 Merge remote-tracking branch 'upstream/master' into bazel-patches 99bfa46 Auto merge of #3593 - arielgabizon:explain-expiry-error, r=daira 57a0418 Repair full_test_suite.py for new checksec.sh. eea0665 Newer version of checksec.sh from slimm609/checksec@a6df608 b3407f0 Auto merge of #1665 - bitbandi:master, r=daira 95a27e9 Auto merge of #4661 - therealyingtong:history-node-garbage-test, r=daira 659a399 Make sure garbage bytes are different ddae981 Auto merge of #4662 - therealyingtong:zip-211-ncc-fixes, r=daira cb3a19f Add test for garbage memory in history nodes 41cf525 Add missing curly braces after if statement 9e117fd Auto merge of #4547 - zebambam:add_libfuzzer_support, r=str4d 58dda60 Added libfuzzer support. f8fa2fc Added support for afl-clang-fast. 027a992 init: Add spans for initialization and shutdown 735503b init: Rework tracing_init call 25d2e6e tracing: Rework tracing_init into a single function 90e86b5 tracing: Parse log_path into an Option<Path> 81446de util: Use DEBUG level for LogPrint(), leaving INFO for LogPrintf() c9879d2 Add fields to logging in CNode and UpdateTip f54f9d5 tracing: Format field values with Display d1e0087 tracing: Add support for span fields 2502ebb Auto merge of #4656 - str4d:depends-fixes, r=str4d 31ba572 tracing: Add support for event fields 4591a4f tracing: Add MAP macro a7f695d FFI: Fix tracing log path handling on Windows 682bc15 depends: Split check-packages and check-sources across categories ddc517b depends: Add platform-specific overrides for download files 2a3770c depends: Rework Rust integration 9487115 Auto merge of #3952 - LongShao007:master, r=daira 2cd6d5c Auto merge of #4460 - rex4539:remove-deprecated-contrib, r=daira b0b8c63 Remove deprecated contrib utilities e0692ed Auto merge of #4642 - str4d:modernise-macos-toolchain, r=str4d bf4730d contrib: Update macdeploy README 927a034 Merge branch 'master' into modernise-macos-toolchain d367185 Auto merge of #4597 - str4d:rust-tracing, r=str4d 1bd4d23 Throw error if -paramsdir not a valid directory beae52e Add paramsdir option for manpage 3b5966e Allow configure params directory 205c7b5 Auto merge of #4653 - str4d:reliable-dependency-fetching, r=str4d 5ada923 Revert "Add check-depends step to STAGE_COMMANDS list" 70c518b depends: tracing-core 0.1.13 c9ca74f qa: Add tracing dependencies to updatecheck.py 695d554 doc: Update release notes for tracing backend 2ae4985 tracing: Document macro arguments that MUST be static constant UTF-8 strings c87205e tracing: Log field values that aren't valid UTF-8 ba831f8 rpc: Throw error in setlogfilter if filter reloading fails 58c4109 init: Place additional constraints on pathDebug 92f1866 FFI: Add missing <stddef.h> includes ba1f455 wallet: Fix logging to satisfy constexpr requirements f57f1c1 tracing: Use 'static constexpr' hack in macros cb294bb FFI: Extract common codeunit types into a rust/types.h header 253ea6d Add some spans to the Zcash codebase aae7583 Add support for tracing spans f89ea3f Add an RPC method for setting the tracing filter directives 3f81f9b Add support for reloading the tracing filter 2b7d824 Use a tracing EnvFilter directive for -debug flags d5de95f Replace C++ logging with tracing logging e04da74 FFI wrapper around tracing crate e6a52fa Add tracing to librustzcash dependencies b654792 Auto merge of #4593 - str4d:proofverifier-refactor, r=str4d 3855cf8 test: Remove obsolete TransactionBuilder test 022c3a4 Auto merge of #4567 - oxarbitrage:issue4537, r=daira 45b2a61 Update Makefile.am 9cdc6f2 depends: Use FALLBACK_DOWNLOAD_PATH if the primary's hash doesn't match 25ef194 Revert "Try downloading from our mirror first to avoid headaches." a4bfd2e Revert "Rename FALLBACK_DOWNLOAD_PATH to PRIORITY_DOWNLOAD_PATH" d6f527a Auto merge of #4650 - teor2345:patch-1, r=daira 5919464 Fix a comment typo in pow.cpp 67ab09a Auto merge of #4646 - defuse:bump-dependency-update-deadlines, r=str4d 902bf83 Add new dependencies to updatecheck.py, add a flag we can use to have our CI test it. 88082c4 Extend deadline for postponing dependency updates 4e3c04c Auto merge of #4588 - nuttycom:remove_amqp, r=str4d 4dd0647 Remove Proton license from contrib/debian/copyright 0391809 Remove amqp code and Proton library depenencies & flags. b383d6c Merge remote-tracking branch 'upstream/master' into bazel-patches bded4ca Auto merge of #4583 - oxarbitrage:issue4495, r=str4d 101857a Limit scope of all global std::once_flag e591f94 Assorted small changes to the locked pool manager 71b79b8 lockedpool: avoid sensitive data in core files (FreeBSD) 6b278b2 lockedpool: When possible, use madvise to avoid including sensitive information in core dumps 4277ef2 Fix segfault in allocator_tests/arena_tests 2882512 Fix compilation errors in support/lockedpool.cpp 3d635dd Fix out-of-bounds write in case of failing mmap(...) in PosixLockedPageAllocator::AllocateLocked e64df07 fix nits: variable naming, typos 1245ce0 Use best-fit strategy in Arena, now O(log(n)) instead O(n) 614d1bb Remove some unused functions and methods 2555074 LockedPool: avoid quadratic-time allocation 817e36b LockedPool: fix explosion for illegal-sized alloc 509652e LockedPool: test handling of invalid allocations d0df44f Do not shadow variable, use deprecated MAP_ANON if MAP_ANONYMOUS is not defined. 088219f bench: Add benchmark for lockedpool allocation/deallocation 82a6675 rpc: Add `getmemoryinfo` call d570eab support: Add LockedPool 8d0f80f wallet: Get rid of LockObject and UnlockObject calls in key.h b997b30 wallet: Change CCrypter to use vectors with secure allocator 2028055 [trivial] Switched constants to sizeof() 2589b2f Auto merge of #4614 - str4d:ctaes, r=str4d fb2edcc Debian: Add copyright entries for ctaes and secp256k1 7e4a74d depends: bump native_cctools for fixed lto with external clang 7a71495 depends: enable lto support for Apple's ld64 25cc992 depends: Add justifications for macOS clang flags b22d180 depends: specify libc++ header location for darwin 6ae5775 depends: Specify path to native binaries as clang argument d6c3af5 depends: Decouple toolchain + binutils a21fa08 doc: explain why passing -mlinker-version is required 6b785ae darwin: pass mlinker-version so that clang enables new features cc934c2 macos: Bump to xcode 11.3.1 and 10.15 SDK a53d5ea depends: bump MacOS toolchain addae3b contrib: macdeploy: Remove historical extraction notes 6296a1e contrib: macdeploy: Use apple-sdk-tools instead of xar+pbzx 8e1a78a native_cctools: Don't use libc++ from pinned clang d02d06b Adapt rest of tooling to new SDK naming scheme 29fbb65 contrib: macdeploy: Correctly generate macOS SDK 79c707a Fix naming of macOS SDK and clarify version d754784 build: use macOS 10.14 SDK a346fc0 depends: native_cctools 921, ld64 409.12, libtapi 1000.10.8 49c023c depends: clang 6.0.1 e04c184 build: set minimum supported macOS to 10.12 d84878d scripted-diff: prefer MAC_OSX over __APPLE__ a0f3ef7 doc: mention that macOS 10.10 is now required 0d3e5fc depends: set OSX_MIN_VERSION to 10.10 63bfdad Fix a return status issue. f39e4db Auto merge of #4627 - LarryRuane:issue4596-flush-wallet-db, r=str4d 454fd23 Update .gitignore. 499d9c2 zcutil/distclean.sh: remove BDB utility programs. 6abcf40 add more allowed duplicates 615efd2 Auto merge of #4584 - defuse:update-ignore, r=str4d 24f3bcf Auto merge of #4623 - str4d:metrics-locking, r=str4d 91cb52a Auto merge of #4606 - str4d:safe-mode-alert-for-pre-heartwood-nodes, r=str4d b1b6512 Auto merge of #4590 - cwsaunders:master, r=str4d e789632 Auto merge of #4640 - therealyingtong:v3.1.0-release-notes-update, r=str4d f7b3a55 Update doc/release-notes/release-notes-3.1.0.md b5ee15b Add Debian8 deprecation to release notes 65f0a47 Auto merge of #4638 - therealyingtong:release-v3.1.0, r=daira 369c16e Set APPROX_RELEASE_HEIGHT to 917000 and update release-notes-3.1.0.md 228b17c make-release.py: Updated release notes and changelog for 3.1.0. f25e86a make-release.py: Updated manpages for 3.1.0. e496338 make-release.py: Versioning changes for 3.1.0. d088832 Auto merge of #4636 - daira:disable-mining-regression, r=daira 162d5a5 Auto merge of #4610 - ebfull:testnet-dev-fund, r=str4d 40b9cbf Allow Equihash validation tests to be compiled with --disable-mining. c99a005 Fix --disable-mining build regression. closes #4634 283287a Use 51 Testnet Dev Fund addresses, and adjust the end heights. 62c3613 Delay testnet activation height by one week de52eed Auto merge of #4628 - therealyingtong:block-903002-bug, r=str4d 04b4d42 Zero-initialize HistoryNode values. 13aa74a Pass HistoryNode struct to librustzcash FFI a65ecaa flush wallet db (SetBestChain()) on clean shutdown 5d15ee1 metrics: Collect general stats before clearing screen d058568 Auto merge of #4617 - daira:release-notes-3.0.0-formatting, r=daira 6631f21 Auto merge of #4616 - daira:4615/hashrate-display, r=daira ab4d2ed Set PROTOCOL_VERSION to 170012 8a4c515 Set Canopy testnet activation height to 1020500 f7c7c76 Fix the formatting of the 3.0.0 release notes. d9307dd Add unit tests for DisplayDuration, DisplaySize, and DisplayHashRate. 460a601 Metrics screen: display hash rates using SI prefixes rather than as powers of 2. 976dce7 src/metrics.cpp: cosmetic whitespace changes. c0a1985 Add dev fund addresses for testnet NU4 activation. 42f98aa Send alert to put pre-Heartwood nodes into safe mode. afd98c5 revert result key change, fix calls to getime 777cda9 Update to Python 3 6ab6279 Updating to Python 3 19f6415 install bdb binaries 8f5dbd3 Enforce pre-release dependency update check in make-release.py 44c35c6 Change release instructions to block the release when dependencies are not updated and not postponed. 75876f4 Implement system for postponing dependency updates. 26522d2 only allow duplicates for certain options of the config 493c0f9 change order of returned pair, fix compatibility issue 18a1448 add timestamp to warnings bb0d3ac explain expiry error 9c96aff fix bug of bdb.mk 4bffaf0 Be consistent with how to #include test data headers 2ee9ce6 Be consistent about what path to include bitcoin-config.h with 39d87d8 Include header files within the source tree using "" instead of <> f56fc01 Don't clobber cwd in rpc_wallet_tests.cpp 86627fe Add missing libsnark initialization call 9b006ce libsnark: Don't (implicitly) rely on other tests initializing the public params 2d8ee6a Remove Checkpoints_tests.cpp f9200ca Fix linkage issue with consts in primitives/block.h 5c4a47c Add actual header file for utilities in gtest/utils.cpp 4109ee3 Add missing #includes to test_block.cpp 0bab947 Get rid of implicit hidden dependencies between test .cpp files 31436e4 Add assert_raises_message to the python test framework. REVERT: 650d13d Rename libzcashconsensus.la -> libzcash_script.la REVERT: 128ba4b Rename zcashconsensus_* -> zcash_script_* in APIs REVERT: 0368fb5 Rename src/script/zcashconsensus.* -> src/script/zcash_script.* REVERT: e5300f8 Fixes after all the merged branches REVERT: 60ad375 prevector: Terminate without logging on failed allocation REVERT: aa1567f Replace boost::optional with std::optional REVERT: 25a225f Replace boost::variant with std::variant REVERT: 6272d92 Remove init_and_check_sodium from crypto/common.h REVERT: f6a5273 Remove JSDescription::h_sig REVERT: 911dd26 Add JSDescriptionInfo for constructing JSDescriptions REVERT: 5575cdd Add amount and consensus branch ID to zcashconsensus_verify_script REVERT: ad3b68c Default to defining endian-conversion DECLs in compat w/o config REVERT: 3aec16a Merge branch 'locked-memory-manager' into zcashconsensus-fixes-base REVERT: e204c5c bench: Add benchmark for lockedpool allocation/deallocation REVERT: 8056a23 rpc: Add `getmemoryinfo` call REVERT: 572a583 support: Add LockedPool REVERT: bf3c73e wallet: Get rid of LockObject and UnlockObject calls in key.h REVERT: a49bd84 wallet: Change CCrypter to use vectors with secure allocator REVERT: b181e6c [trivial] Switched constants to sizeof() REVERT: 84bb6fe Merge branch 'c++17' into zcashconsensus-fixes-base REVERT: 50ef461 Merge branch 'proofverifier-refactor' into zcashconsensus-fixes-base REVERT: 622427d Remove crypto/equihash from libzcashconsensus REVERT: e1a5132 Replace libsodium's crypto_generichash_blake2b with blake2b_simd REVERT: 9514e40 Replace libsodium's randombytes_buf with rand_core::OsRng::fill_bytes REVERT: 3f3e9d2 depends: Build C++ dependencies with C++ 17 REVERT: 08b9c99 build: Require and build with C++ 17 REVERT: ed9c927 build: Update AX_CXX_COMPILE_STDCXX macro git-subtree-dir: depend/zcash git-subtree-split: d94fe7678b49dce57c8a71ffe44b28d5b57eddd6
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR the zcash script verification logic in zebra has had an issue with quadratic serialization of transactions when verifying scripts. In the script verification API each input is verified individually. This would be fine, except for the fact that we also have to deal with FFI to another language with a different representation for transactions, which requires that we serialize and deserialize each transaction for each call into c++ code.
This PR solves this problem by exporting the newly setup "precomputed transaction" API, which lets us serialize our transaction once, pass it over, have zcash_script deserialize it once, and then pass us a
void*
pointer to the data they'd need for future function calls to verify individual transaction inputs. We then hold onto this pointer and pass it back into the C++ code for each input we verify, which prevents us from needing to do any more serialization for the duration of that transaction verification.