Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump rand_core from 0.6.3 to 0.6.4, fixes unsoundness bug #5175

Merged
merged 1 commit into from Sep 28, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 15, 2022

Bumps rand_core from 0.6.3 to 0.6.4.

Changelog

Sourced from rand_core's changelog.

[0.6.4] - 2019-01-08

Fixes

  • Move wasm-bindgen shims to correct crate (#686)
  • Make wasm32-unknown-unknown compile but fail at run-time if missing bindingsg (#686)
Commits
  • 4336232 Merge pull request #686 from dhardy/master
  • 1d07496 Fix changelogs and bump rand_os version number
  • 5142481 Merge remote-tracking branch 'origin/master' and update changelog
  • afc9d9a Merge pull request #670 from akash-fortanix/sgx-target
  • e1e4005 Update changelog
  • 1ad20a7 Generalise WASM tests
  • 94efb40 Remove remaining WASM remnants from rand to rand_os
  • f7bfa1a rand_os: use run-time failure on unsupported WASM platforms
  • 42ece4f Document and correct usage of new rand_os "feature"
  • 1d97fa1 remove winapi feature
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from a team as a code owner September 15, 2022 15:03
@dependabot dependabot bot requested review from arya2 and removed request for a team September 15, 2022 15:03
@dependabot dependabot bot added A-dependencies Area: Dependency file updates A-rust Area: Updates to Rust code P-Low ❄️ labels Sep 15, 2022
@teor2345 teor2345 added the C-cleanup Category: This is a cleanup label Sep 20, 2022
@teor2345 teor2345 requested review from dconnolly and removed request for arya2 September 20, 2022 20:28
@teor2345 teor2345 assigned dconnolly and unassigned arya2 Sep 20, 2022
@teor2345
Copy link
Contributor

@dconnolly is going to do this review.

@dconnolly
Copy link
Contributor

@mergify rebase

@mergify
Copy link
Contributor

mergify bot commented Sep 26, 2022

rebase

✅ Branch has been successfully rebased

@teor2345 teor2345 force-pushed the dependabot/cargo/rand_core-0.6.4 branch from 34b1f6b to 495a37f Compare September 26, 2022 21:22
@codecov
Copy link

codecov bot commented Sep 26, 2022

Codecov Report

Merging #5175 (74d17f6) into main (8ddc508) will decrease coverage by 0.04%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5175      +/-   ##
==========================================
- Coverage   79.15%   79.10%   -0.05%     
==========================================
  Files         307      307              
  Lines       39248    39248              
==========================================
- Hits        31066    31048      -18     
- Misses       8182     8200      +18     

@teor2345
Copy link
Contributor

@dependabot recreate

@dependabot dependabot bot force-pushed the dependabot/cargo/rand_core-0.6.4 branch from 495a37f to 5776696 Compare September 27, 2022 21:17
teor2345
teor2345 previously approved these changes Sep 27, 2022
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reduces unsafe and fixes some unsoundness, we want this.

@teor2345 teor2345 added C-bug Category: This is a bug C-security Category: Security issues I-memory-safety Vulnerable code in Zebra or dependencies and removed P-Low ❄️ labels Sep 27, 2022
@teor2345 teor2345 changed the title build(deps): bump rand_core from 0.6.3 to 0.6.4 build(deps): bump rand_core from 0.6.3 to 0.6.4, fixes unsoundness bug Sep 27, 2022
@teor2345 teor2345 added P-Medium ⚡ and removed C-cleanup Category: This is a cleanup labels Sep 27, 2022
@dconnolly
Copy link
Contributor

@mergify rebase

Bumps [rand_core](https://github.com/rust-random/rand) from 0.6.3 to 0.6.4.
- [Release notes](https://github.com/rust-random/rand/releases)
- [Changelog](https://github.com/rust-random/rand/blob/master/CHANGELOG.md)
- [Commits](rust-random/rand@rand_core-0.6.3...0.6.4)

---
updated-dependencies:
- dependency-name: rand_core
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@mergify
Copy link
Contributor

mergify bot commented Sep 27, 2022

rebase

✅ Branch has been successfully rebased

Copy link
Contributor

@dconnolly dconnolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removes several usages of unsafe, lgtm

mergify bot added a commit that referenced this pull request Sep 28, 2022
@mergify mergify bot merged commit da060e4 into main Sep 28, 2022
@mergify mergify bot deleted the dependabot/cargo/rand_core-0.6.4 branch September 28, 2022 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dependencies Area: Dependency file updates A-rust Area: Updates to Rust code C-bug Category: This is a bug C-security Category: Security issues I-memory-safety Vulnerable code in Zebra or dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants