Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new compatibility variable to UXLabel #3

Merged
merged 2 commits into from
Dec 23, 2023
Merged

Add new compatibility variable to UXLabel #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7bd19de
Properly define the package description
martindufort Dec 14, 2023
60f46b2
Add back files deleted by error
martindufort Dec 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,17 @@
// swift-tools-version:5.1

import PackageDescription

let package = Package(
name: "UXKit",

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't the excludes necessary to build w/o warnings? 🤔
Also, we have a specific 5.1 Package manifest. Ah, maybe they haven't been necessary w/ 5.1 but are with newer Swift versions? (when SPM gained resource support).

exclude: [
"UXKit.xcodeproj",
"GNUmakefile",
"LICENSE",
"README.md",
"xcconfig"
]
platforms: [
.macOS(.v10_12), .iOS(.v10)
],
products: [
.library(name: "UXKit", targets: ["UXKit"]),
],
dependencies: [],
targets: [
.target(name:"UXKit")
]
)
7 changes: 7 additions & 0 deletions Sources/UXKit/AppKit/UXView-AppKit.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,13 @@

}

public extension UXLabel {
var text: String {
set { stringValue = newValue }
get { return stringValue }
}
}

public extension UXSpinner {
/// Use this instead of `isDisplayedWhenStopped` for UIKit compatibility.
var hidesWhenStopped : Bool {
Expand Down
Loading