0.3.7-rc2 #49
Merged
0.3.7-rc2 #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If using django settings only, and the settings file imports a model, django will fail hard on startup. This could be common scenario for the JOB_MAPPING setting which takes a key of a string and the value is the function to execute. Thus, if the file that the function lives in imports a django model, the app will not be initialized yet.
tpilara
approved these changes
Mar 15, 2018
zc_events/config.py
Outdated
| self._settings = django_settings | ||
| else: | ||
| import_path = os.environ.get('ZC_EVENTS_SETTINGS') | ||
| if import_path: | ||
| logger.debug('zc_events could not use django settings, using ZC_EVENTS_SETTINGS') |
There was a problem hiding this comment.
This log message reflects the old order of checking settings modules
| @@ -54,6 +50,9 @@ def __getattr__(self, name): | |||
| ) | |||
| ) | |||
| raise e | |||
| elif django_settings: | |||
There was a problem hiding this comment.
Although unlikely, what would happen if import_path and django_settings both evaluated to False?
zc_events/config.py
Outdated
| logger.debug('zc_events could not use django settings, using ZC_EVENTS_SETTINGS') | ||
| import_path = os.environ.get('ZC_EVENTS_SETTINGS') | ||
| try: | ||
| self._settings = importlib.import_module(import_path) | ||
| except Exception as e: |
There was a problem hiding this comment.
I'd prefer this to be a tighter exception catch (I think it would be ImportError) if possible.
ograycode
force-pushed
the
og/reconfigure-settings
branch
from
49ec2fc
to
c0c22a7
Compare
|
We are test driving code climate. It brought up some valid issues, and I'll address them before we drop the release candidate version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does a couple of things:
Makes it so the environment variable
ZC_EVENTS_SETTINGSis used first, and django settings is the backup. This was done becauseJOB_MAPPINGrequires you to import the actual task to run, and that might import a part of the django code that is not ready yet -- leading to an app configuration error.Lazy evaluation of redis and rabbitmq connections so it only happens when needed. These read off settings which may not be available yet, leading to errors.
Updates setup.py file for 0.3.7-rc2.