DASH-1506: Emit Push notification events #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anderson12ho
force-pushed
the
anderson12ho/push-events
branch
5 times, most recently
from
5227a90
to
15adf68
Compare
anderson12ho
force-pushed
the
anderson12ho/push-events
branch
2 times, most recently
from
57316c1
to
c3bf606
Compare
anderson12ho
force-pushed
the
anderson12ho/push-events
branch
from
c3bf606
to
a1356a2
Compare
anderson12ho
force-pushed
the
anderson12ho/push-events
branch
from
715226b
to
0959074
Compare
anderson12ho
force-pushed
the
anderson12ho/push-events
branch
from
bd0062b
to
a580b5e
Compare
anderson12ho
commented
Jan 27, 2021
Comment on lines
+263
to
+265
| def emit_microservice_message( # pylint: disable=keyword-arg-before-vararg | ||
| self, exchange, routing_key, event_type, priority=0, *args, **kwargs | ||
| ): |
There was a problem hiding this comment.
pylint doesnt like having default value keyword arguments before *args, **kwargs but I don't want to refactor the signature at this time.
anderson12ho
commented
Jan 27, 2021
| @@ -1,5 +1,5 @@ | |||
| try: | |||
| from django.core.exceptions import ImproperlyConfigured | |||
| from django.core.exceptions import ImproperlyConfigured # pylint: disable=unused-import | |||
There was a problem hiding this comment.
I'm not sure why this was necessary, but I think we can just import this without having the except case once we update our django version.
anderson12ho
commented
Jan 27, 2021
Comment on lines
+59
to
+65
| args, a, kw, defaults = inspect.getargspec(func) # pylint: disable=deprecated-method | ||
|
|
||
| signature = inspect.formatargspec(args, a, kw, defaults) | ||
| signature = inspect.formatargspec(args, a, kw, defaults) # pylint: disable=deprecated-method | ||
| is_bound_method = hasattr(func, '__self__') | ||
| if is_bound_method: | ||
| args = args[1:] # Omit 'self' | ||
| callargs = inspect.formatargspec(args, a, kw, None) | ||
| callargs = inspect.formatargspec(args, a, kw, None) # pylint: disable=deprecated-method |
There was a problem hiding this comment.
getargspec and formatargspec are deprecated in python 3.5, didn't want to spend time figuring out the new replacements
anderson12ho
commented
Jan 27, 2021
| @@ -166,6 +166,7 @@ def activate(self, func): | |||
| return get_wrapped(func, _wrapper_template, evaldict) | |||
|
|
|||
| def _find_match(self, resource_type, **kwargs): | |||
There was a problem hiding this comment.
this function was super unintuitive using a for/else loop. I didn't want to refactor it since I don't know how it will be have. This is my workaround.
tpilara
approved these changes
Jan 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add emitter for push notification events