Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Razor model improvements #4270

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Sharkgamedev
Copy link
Contributor

Makes Razor look a bit better, instead of it being a hexagon trying it's hardest to be a circle it is now a circle, I've also touched up the doors to make their edges a little better as well as the inside circle. Finally, under the guidance of ShadowFury I was able to improve the metallic/smoothness map on it as well. Note: If ao plate is not strong enough set decal size to 7, I just wasn't sure if that was too strong so I did 6. There are also a few new unittextures which were leftover from me messing around trying different things, I figured I'd leave them in case they could be used in the future. It also got a new buildpic for the slight difference. Death clone has not been updated however as I didn't see the need, I can do it sometime if it is more important.
Tris count increase 2x, from 776 > 1554
Not sure about colvols, this is how they look at the moment:
image
Before
image
After
image
Before
image
After
image

Makes Razor look a bit better, instead of it being a hexagon trying it's hardest to be a circle it is now a cirlce, I've also touched up the doors to make their edges a little better as well as the inside circle. Finally under the guidance of ShadowFury I was able to improve the metallic/smoothness map on it as well. Note: If ao plate is not strong enough set decal size to 7, I just wasn't sure if that was too strong so I did 6. There are also a few new unittextures which were leftover from me messing around trying different things, I figured I'd leave them in case they could be used in the future. It also got a new buildpic for the slight difference. Death clone has not been updated however as I didn't see the need, I can do it sometime if it is more important.
Decreases the metallic (blue) on the inside of the 'barrells' to bring back the contrast.
@GoogleFrog
Copy link
Contributor

buildingGroundDecalSize should not be edited as it is derived from footprint. Ideally you would regenerate the ground decal with the aoplane generator. I think it can be found in tools.

@Sharkgamedev
Copy link
Contributor Author

buildingGroundDecalSize should not be edited as it is derived from footprint. Ideally you would regenerate the ground decal with the aoplane generator. I think it can be found in tools.

Aoplane generator seems to be a bit finicky, is using Blender to generate it not ok? I had done it with blender before at 256 x 256 but I guess that was lower res than the old one so that's why it didn't fit? I could rebake it with a higher res in Blender or just scale it in Gimp.

@sprunk sprunk changed the title Razor Rework/Update Razor model improvements Apr 7, 2021
Uses an aoplane baked via aobaker.py
@Sharkgamedev
Copy link
Contributor Author

buildingGroundDecalSize should not be edited as it is derived from footprint. Ideally you would regenerate the ground decal with the aoplane generator. I think it can be found in tools.

Done!

Copy link
Member

@sprunk sprunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. What are these files for? If they aren't used they probably belong to the artwork repo.
  • unittextures/razor_shiny_metal.dds
  • unittextures/razor_shiny_metal_lesssmooth.dds
  • unittextures/razor_shiny_metal_smooth.dds
  1. The unitpic should have "floating" (water/land) but it has "amphibious" (land/underwater) background. This sounds like an issue with the generator, I'll check it over the weekend.

  2. A minor thing but the new AO is 340 kB while the old one was 20 kB, looks a bit suspicious. It would probably be good to compress it.

@Sharkgamedev
Copy link
Contributor Author

@sprunk The aoplate generator gave me infinite trouble so I'm not surprised that something like that happened... I'll see what I can do about compression in gimp.

Those extra files were just different iterations of the texture, my mistake for leaving them in.

I remember making some modifications to the buildpic generator locally. That could have contributed to the problem, Ive since reverted the changes but I can't remember if I generated the build pic before or after that. I'll try regenerating it now and see if that resolves the issue.

@GoogleFrog
Copy link
Contributor

The base is certainly rounder, which is good, but the texture overall seems darker and messier. The top of the old Razor fairly crisp and the ring is consistently white. The PR Razor has a bunch of weird triangle artifacts and is generally quite dark.

image

@Sharkgamedev
Copy link
Contributor Author

The base is certainly rounder, which is good, but the texture overall seems darker and messier. The top of the old Razor fairly crisp and the ring is consistently white. The PR Razor has a bunch of weird triangle artifacts and is generally quite dark.

image

Hmn looks like their may be some incorrect normals on that. The body is darker to because it's more metallic, I can definitely turn that down around the ring to improve contrast.

@sprunk
Copy link
Member

sprunk commented Jun 19, 2021

I checked the icon generator and while my potato PC fails to actually render units there, it draws backgrounds and Razor has the correct "floating" (water/land) background with an unmodified model.

Try building an icon using the unmodified model and see if it works. If yes then that would point to some issue with the new model. Maybe it has too huge of a model radius (extending too far underwater)?

@sprunk
Copy link
Member

sprunk commented Mar 26, 2022

Any advances?

@sprunk
Copy link
Member

sprunk commented Jul 9, 2023

Annual ping for progress (I see that there was a thumbs-up the last time so I assume something is slowly happening).

@sprunk sprunk marked this pull request as draft October 28, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants